Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 9509001: Add basic threaded compositor test to gpu_feature_browsertest.cc (Closed)

Created:
8 years, 9 months ago by jbates
Modified:
8 years, 9 months ago
Reviewers:
Zhenyao Mo, nduca
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : disabled chrome os #

Patch Set 3 : flakiness fix #

Patch Set 4 : disabling because of assertion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M chrome/test/data/gpu/feature_compositing.html View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/test/gpu/gpu_feature_browsertest.cc View 1 2 3 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jbates
ptal
8 years, 9 months ago (2012-02-28 17:54:44 UTC) #1
Zhenyao Mo
On 2012/02/28 17:54:44, jbates wrote: > ptal LGTM
8 years, 9 months ago (2012-02-28 17:55:46 UTC) #2
nduca
That is very cool LGTM
8 years, 9 months ago (2012-02-28 20:48:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbates@chromium.org/9509001/1
8 years, 9 months ago (2012-02-29 23:28:13 UTC) #4
commit-bot: I haz the power
Change committed as 124346
8 years, 9 months ago (2012-03-01 03:03:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbates@chromium.org/9509001/10001
8 years, 9 months ago (2012-03-01 21:52:12 UTC) #6
commit-bot: I haz the power
Change committed as 124562
8 years, 9 months ago (2012-03-02 01:29:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbates@chromium.org/9509001/17001
8 years, 9 months ago (2012-03-03 01:16:09 UTC) #8
commit-bot: I haz the power
8 years, 9 months ago (2012-03-03 01:16:15 UTC) #9
Can't apply patch for file chrome/test/data/gpu/feature_compositing.html.
While running patch -p1 --forward --force;
patching file chrome/test/data/gpu/feature_compositing.html
Hunk #1 FAILED at 10.
Hunk #2 FAILED at 18.
2 out of 2 hunks FAILED -- saving rejects to file
chrome/test/data/gpu/feature_compositing.html.rej

Powered by Google App Engine
This is Rietveld 408576698