Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 9508007: Add a 32-bit gold binary and use it. (Closed)

Created:
8 years, 9 months ago by Lei Zhang
Modified:
8 years, 9 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews
Visibility:
Public.

Description

Add a 32-bit gold binary and use it. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124239

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
A gold32 View Binary file 0 comments Download
M ld View 1 1 chunk +8 lines, -5 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
I personally don't care, but apparently we have some bots that do.
8 years, 9 months ago (2012-02-29 02:34:01 UTC) #1
Evan Martin
LGTM https://chromiumcodereview.appspot.com/9508007/diff/1/ld File ld (right): https://chromiumcodereview.appspot.com/9508007/diff/1/ld#newcode21 ld:21: exec ld "$@" Should we error out here? ...
8 years, 9 months ago (2012-02-29 16:17:48 UTC) #2
Lei Zhang
https://chromiumcodereview.appspot.com/9508007/diff/1/ld File ld (right): https://chromiumcodereview.appspot.com/9508007/diff/1/ld#newcode21 ld:21: exec ld "$@" On 2012/02/29 16:17:48, Evan Martin wrote: ...
8 years, 9 months ago (2012-02-29 20:22:56 UTC) #3
Evan Martin
8 years, 9 months ago (2012-02-29 20:25:48 UTC) #4
LGTM++

https://chromiumcodereview.appspot.com/9508007/diff/5001/ld
File ld (right):

https://chromiumcodereview.appspot.com/9508007/diff/5001/ld#newcode20
ld:20: echo Unknown architecture
Maybe include the script name, so that someone who hits this can track it down.

echo "$0: Unknown architecture"

Powered by Google App Engine
This is Rietveld 408576698