Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/browser/sync/sync_prefs_unittest.cc

Issue 9500005: Add a declarative way in c/b/s/sync_prefs.cc to say which data types have prefs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: akalin comments Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/sync_prefs_unittest.cc
diff --git a/chrome/browser/sync/sync_prefs_unittest.cc b/chrome/browser/sync/sync_prefs_unittest.cc
index 0064137ab582d02e40377720713970def0939d21..e89bf469922329b97aad3a0ba3d0625224d2f721 100644
--- a/chrome/browser/sync/sync_prefs_unittest.cc
+++ b/chrome/browser/sync/sync_prefs_unittest.cc
@@ -36,9 +36,11 @@ syncable::ModelTypeSet GetNonPassiveTypes() {
// Returns all types visible from the setup UI.
syncable::ModelTypeSet GetUserVisibleTypes() {
syncable::ModelTypeSet user_visible_types(GetNonPassiveTypes());
+ user_visible_types.Remove(syncable::APP_NOTIFICATIONS);
+ user_visible_types.Remove(syncable::APP_SETTINGS);
user_visible_types.Remove(syncable::AUTOFILL_PROFILE);
+ user_visible_types.Remove(syncable::EXTENSION_SETTINGS);
user_visible_types.Remove(syncable::SEARCH_ENGINES);
- user_visible_types.Remove(syncable::APP_NOTIFICATIONS);
return user_visible_types;
}
@@ -112,6 +114,10 @@ TEST_F(SyncPrefsTest, PreferredTypesNotKeepEverythingSynced) {
}
if (it.Get() == syncable::APPS) {
expected_preferred_types.Put(syncable::APP_NOTIFICATIONS);
+ expected_preferred_types.Put(syncable::APP_SETTINGS);
+ }
+ if (it.Get() == syncable::EXTENSIONS) {
+ expected_preferred_types.Put(syncable::EXTENSION_SETTINGS);
}
sync_prefs.SetPreferredDataTypes(non_passive_types, preferred_types);
EXPECT_TRUE(expected_preferred_types.Equals(

Powered by Google App Engine
This is Rietveld 408576698