Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9500003: Add a button to exit managed mode. (Closed)

Created:
8 years, 9 months ago by Bernhard Bauer
Modified:
7 years, 4 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, achuith+watch_chromium.org, Pam (message me for reviews), Robert Sesek, binji
Visibility:
Public.

Description

Add a button to exit managed mode in place of the profile avatar. BUG=116060 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134308

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : sync #

Patch Set 4 : sync #

Patch Set 5 : sync #

Patch Set 6 : fix #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Total comments: 1

Patch Set 10 : update #

Total comments: 5

Patch Set 11 : update #

Patch Set 12 : review #

Total comments: 6

Patch Set 13 : review #

Patch Set 14 : review #

Total comments: 4

Patch Set 15 : review #

Patch Set 16 : fix #

Patch Set 17 : fix #

Patch Set 18 : fix #

Patch Set 19 : fix win #

Patch Set 20 : fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -179 lines) Patch
M chrome/app/theme/theme_resources.grd View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/managed_mode.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/managed_mode.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/profiles/avatar_menu_model.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/avatar_menu_model.cc View 1 2 3 4 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +12 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_button_controller.mm View 1 2 3 4 5 6 7 8 9 10 11 12 7 chunks +40 lines, -24 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.h View 1 2 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm View 1 2 5 chunks +6 lines, -27 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm View 1 2 3 4 5 6 7 8 9 10 4 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 2 3 4 5 6 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/avatar_menu_button_gtk.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 6 chunks +37 lines, -37 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_button.h View 1 2 3 4 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_button.cc View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +20 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +41 lines, -29 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 3 chunks +7 lines, -22 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_login_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +5 lines, -1 line 1 comment Download

Messages

Total messages: 27 (0 generated)
Bernhard Bauer
Please review. Sailesh: profiles Nico: Cocoa Evan: WebUI/Gtk Scott: Views Thanks!
8 years, 8 months ago (2012-04-25 11:19:44 UTC) #1
Nico
cocoa lgtm https://chromiumcodereview.appspot.com/9500003/diff/44001/chrome/browser/ui/cocoa/browser/avatar_button_controller.mm File chrome/browser/ui/cocoa/browser/avatar_button_controller.mm (right): https://chromiumcodereview.appspot.com/9500003/diff/44001/chrome/browser/ui/cocoa/browser/avatar_button_controller.mm#newcode255 chrome/browser/ui/cocoa/browser/avatar_button_controller.mm:255: return; +1
8 years, 8 months ago (2012-04-25 13:30:15 UTC) #2
Nico
(Land the pngs TBR then you can send try jobs for that. But you know ...
8 years, 8 months ago (2012-04-25 13:30:56 UTC) #3
Bernhard Bauer
On 2012/04/25 13:30:56, Nico wrote: > (Land the pngs TBR then you can send try ...
8 years, 8 months ago (2012-04-25 13:40:43 UTC) #4
sky
https://chromiumcodereview.appspot.com/9500003/diff/41002/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc File chrome/browser/ui/views/frame/browser_non_client_frame_view.cc (right): https://chromiumcodereview.appspot.com/9500003/diff/41002/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc#newcode41 chrome/browser/ui/views/frame/browser_non_client_frame_view.cc:41: gfx::Image avatar; Is there some place else this code ...
8 years, 8 months ago (2012-04-25 17:12:26 UTC) #5
Bernhard Bauer
https://chromiumcodereview.appspot.com/9500003/diff/41002/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc File chrome/browser/ui/views/frame/browser_non_client_frame_view.cc (right): https://chromiumcodereview.appspot.com/9500003/diff/41002/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc#newcode41 chrome/browser/ui/views/frame/browser_non_client_frame_view.cc:41: gfx::Image avatar; On 2012/04/25 17:12:26, sky wrote: > Is ...
8 years, 8 months ago (2012-04-25 17:57:30 UTC) #6
sail
+binji: who wrote the GTK ui +rsesek: who wrote the Cocoa UI and the avatar ...
8 years, 8 months ago (2012-04-25 18:02:46 UTC) #7
binji
gtk lgtm, though it took me some time to figure out what "managed mode" is ...
8 years, 8 months ago (2012-04-25 18:30:07 UTC) #8
Evan Stade
https://chromiumcodereview.appspot.com/9500003/diff/48002/chrome/browser/ui/gtk/browser_titlebar.cc File chrome/browser/ui/gtk/browser_titlebar.cc (right): https://chromiumcodereview.appspot.com/9500003/diff/48002/chrome/browser/ui/gtk/browser_titlebar.cc#newcode127 chrome/browser/ui/gtk/browser_titlebar.cc:127: gfx::Image GetManagedModeAvatar() { I don't think defining this function ...
8 years, 8 months ago (2012-04-25 19:26:04 UTC) #9
sky
LGTM https://chromiumcodereview.appspot.com/9500003/diff/41002/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc File chrome/browser/ui/views/frame/browser_non_client_frame_view.cc (right): https://chromiumcodereview.appspot.com/9500003/diff/41002/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc#newcode41 chrome/browser/ui/views/frame/browser_non_client_frame_view.cc:41: gfx::Image avatar; On 2012/04/25 17:57:30, Bernhard Bauer wrote: ...
8 years, 8 months ago (2012-04-25 19:44:33 UTC) #10
Bernhard Bauer
https://chromiumcodereview.appspot.com/9500003/diff/48002/chrome/browser/ui/gtk/browser_titlebar.cc File chrome/browser/ui/gtk/browser_titlebar.cc (right): https://chromiumcodereview.appspot.com/9500003/diff/48002/chrome/browser/ui/gtk/browser_titlebar.cc#newcode127 chrome/browser/ui/gtk/browser_titlebar.cc:127: gfx::Image GetManagedModeAvatar() { On 2012/04/25 19:26:05, Evan Stade wrote: ...
8 years, 8 months ago (2012-04-26 16:46:15 UTC) #11
sail
LGTM! A couple things that might be worth testing: - avatar menu from ntp - ...
8 years, 8 months ago (2012-04-26 17:39:15 UTC) #12
Evan Stade
gtk lgtm https://chromiumcodereview.appspot.com/9500003/diff/61002/chrome/browser/ui/gtk/browser_titlebar.cc File chrome/browser/ui/gtk/browser_titlebar.cc (right): https://chromiumcodereview.appspot.com/9500003/diff/61002/chrome/browser/ui/gtk/browser_titlebar.cc#newcode828 chrome/browser/ui/gtk/browser_titlebar.cc:828: return; nit: \n https://chromiumcodereview.appspot.com/9500003/diff/61002/chrome/browser/ui/gtk/browser_titlebar.cc#newcode1093 chrome/browser/ui/gtk/browser_titlebar.cc:1093: return false; ...
8 years, 8 months ago (2012-04-26 18:27:51 UTC) #13
Bernhard Bauer
http://codereview.chromium.org/9500003/diff/61002/chrome/browser/ui/gtk/browser_titlebar.cc File chrome/browser/ui/gtk/browser_titlebar.cc (right): http://codereview.chromium.org/9500003/diff/61002/chrome/browser/ui/gtk/browser_titlebar.cc#newcode828 chrome/browser/ui/gtk/browser_titlebar.cc:828: return; On 2012/04/26 18:27:51, Evan Stade wrote: > nit: ...
8 years, 8 months ago (2012-04-27 08:59:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/9500003/32022
8 years, 8 months ago (2012-04-27 08:59:35 UTC) #15
commit-bot: I haz the power
Try job failure for 9500003-32022 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-27 09:16:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/9500003/76001
8 years, 8 months ago (2012-04-27 09:28:24 UTC) #17
commit-bot: I haz the power
Try job failure for 9500003-76001 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-27 09:46:57 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/9500003/32023
8 years, 8 months ago (2012-04-27 11:42:48 UTC) #19
commit-bot: I haz the power
Try job failure for 9500003-32023 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-27 11:58:52 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/9500003/75003
8 years, 8 months ago (2012-04-27 13:07:29 UTC) #21
commit-bot: I haz the power
Try job failure for 9500003-75003 (retry) on win_rel for steps "ui_tests, browser_tests". It's a second ...
8 years, 8 months ago (2012-04-27 15:50:36 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/9500003/69006
8 years, 8 months ago (2012-04-27 16:23:00 UTC) #23
commit-bot: I haz the power
Try job failure for 9500003-69006 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-27 16:49:36 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/9500003/68027
8 years, 8 months ago (2012-04-27 16:59:13 UTC) #25
commit-bot: I haz the power
Change committed as 134308
8 years, 8 months ago (2012-04-27 18:27:17 UTC) #26
Dan Beam
7 years, 4 months ago (2013-08-12 19:40:28 UTC) #27
Message was sent while issue was closed. 
https://codereview.chromium.org/9500003/diff/68027/chrome/browser/ui/webui/nt...
File chrome/browser/ui/webui/ntp/ntp_login_handler.cc (right):

https://codereview.chromium.org/9500003/diff/68027/chrome/browser/ui/webui/nt...
chrome/browser/ui/webui/ntp/ntp_login_handler.cc:144: IDC_SHOW_AVATAR_MENU)) {
bauerb@: ^ why was this check added?  this means that clicking the signed in
username no-ops when chrome has only 1 profile.  see crbug.com/269657 for more
context and crrev.com/22606003 for the proposed solution.

Powered by Google App Engine
This is Rietveld 408576698