Rename blahHandler to onBlah throughout dart:io.

Rename blahHandler to onBlah throughout dart:io.

Additionally, change all single-shot methods to take their callback as an argument instead of registering it on the object.

I have attempted to find all uses in the repo but there might
be some firefighting to do when this lands.

R=sgjesse@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=4784

[Mads Ager (google), 2012-02-28 17:33:33]

The stable test binaries will have to be updated as part of this as well. I will
do that once we are happy with the change.

[Søren Gjesse, 2012-02-29 07:41:24]

I think we should discuss some of the names. Of cause it is easy to match the
event handler setter when the XXX in onXXX is the same as the function called,
but for e.g create onCreated to me sounds better that onCreate. Same for close
and many of the others. However onExited on Process is perhaps not the best.

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/directory....
File runtime/bin/directory.dart (right):

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/directory....
runtime/bin/directory.dart:126: void set onCreate(void onCreate());
Wondering whether this should be onCreated instead of onCreate.

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/directory....
runtime/bin/directory.dart:132: void set onCreateTemp(void onCreateTemp());
Same here onTempCreated?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/directory....
runtime/bin/directory.dart:138: void set onDelete(void onDelete());
onDeleted?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/file.dart
File runtime/bin/file.dart (right):

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/file.dart#...
runtime/bin/file.dart:212: void set onCreate(void handler());
onCreated?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/file.dart#...
runtime/bin/file.dart:218: void set onDelete(void handler());
onDeleted?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/file.dart#...
runtime/bin/file.dart:230: void set onOpen(void handler(RandomAccessFile
openedFile));
OnOpened?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/file.dart#...
runtime/bin/file.dart:415: void set onReadByte(void handler(int byte));
onByteRead?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/file.dart#...
runtime/bin/file.dart:421: void set onReadList(void handler(int read));
onListRead?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/file.dart#...
runtime/bin/file.dart:427: void set onNoPendingWrite(void handler());
onNoPendingWrites (with an s)?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/file.dart#...
runtime/bin/file.dart:439: void set onSetPosition(void handler());
OnPositionSet?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/file.dart#...
runtime/bin/file.dart:445: void set onTruncate(void handler());
OnTruncated?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/file.dart#...
runtime/bin/file.dart:457: void set onFlush(void handler());
onFlushed?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/input_stre...
File runtime/bin/input_stream.dart (right):

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/input_stre...
runtime/bin/input_stream.dart:92: void set onClose(void callback());
onClosed?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/input_stre...
runtime/bin/input_stream.dart:156: void set onClose(void callback());
onClosed?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/input_stre...
runtime/bin/input_stream.dart:211: void set onClose(void callback());
onClosed?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/output_str...
File runtime/bin/output_stream.dart (right):

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/output_str...
runtime/bin/output_stream.dart:62: void set onNoPendingWrite(void callback());
onNoPendingWrites?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/output_str...
runtime/bin/output_stream.dart:69: void set onClose(void callback());
onClosed?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/process.dart
File runtime/bin/process.dart (right):

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/process.da...
runtime/bin/process.dart:47: void set onStart(void callback());
onStarted?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/socket.dart
File runtime/bin/socket.dart (right):

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/socket.dar...
runtime/bin/socket.dart:68: void set onConnect(void callback());
onConnected?

https://chromiumcodereview.appspot.com/9500002/diff/59/runtime/bin/socket.dar...
runtime/bin/socket.dart:86: void set onClose(void callback());
onClosed?

[Mads Ager (google), 2012-02-29 08:15:41]

I agree. I'll do a sweep through all the onBlah names now and update.

[Mads Ager (google), 2012-02-29 11:16:52]

Having looking into this some more I think this awkwardness in naming the event
handlers is an indication that we should not have most of them. We have been
discussing switching to passing in the handler for the one shot methods. I think
now is the time to do that. I will morph this change into a change that does
that instead.

[Mads Ager (google), 2012-02-29 14:57:32]

Changed all one-shot methods to take their callback as an argument.

Directory listing should be redone. Probably by taking only one callback that is
called with a tag for each string telling it if it is a directory name or a file
name or whether the listing is done.

PTAL

[Søren Gjesse, 2012-02-29 15:42:20]

LGTM!

https://chromiumcodereview.appspot.com/9500002/diff/8007/runtime/bin/director...
File runtime/bin/directory.dart (right):

https://chromiumcodereview.appspot.com/9500002/diff/8007/runtime/bin/director...
runtime/bin/directory.dart:53: void createTemp(void callback());
Maybe we should consider changing the behaviour of createTemp, so that it does
not change the existing directory object, but creates a new one for the temp
directory and gives that to the callback.

We can discuss that and postpone to a separate change.

https://chromiumcodereview.appspot.com/9500002/diff/8007/runtime/bin/director...
runtime/bin/directory.dart:63: void createTempSync();
Then this should return a new Directory object.

https://chromiumcodereview.appspot.com/9500002/diff/8007/runtime/bin/director...
File runtime/bin/directory_impl.dart (right):

https://chromiumcodereview.appspot.com/9500002/diff/8007/runtime/bin/director...
runtime/bin/directory_impl.dart:89: _onError("Could not create temporary
directory [$_path]: " +
Indentation.

https://chromiumcodereview.appspot.com/9500002/diff/8007/runtime/bin/director...
runtime/bin/directory_impl.dart:108: void delete(bool recursive, void
callback()) {
We should consider revising this to not take a boolean argument writing this to
delete a directory looks a bit strange:

d.delete(false, () => print("done"))
d.delete(true, () => print("done"))

What is a "false" deletion of a directory?

How about


d.delete(() => print("done"))
d.deleteRecursive(() => print("done"))

or


d.delete(DeleteMode.NON_RECURSIVE, () => print("done"))
d.delete(DeleteMode.RECURSIVE, () => print("done"))

https://chromiumcodereview.appspot.com/9500002/diff/8007/tests/standalone/src...
File tests/standalone/src/ProcessTestUtil.dart (right):

https://chromiumcodereview.appspot.com/9500002/diff/8007/tests/standalone/src...
tests/standalone/src/ProcessTestUtil.dart:1: // Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
No need to change this.

[Mads Ager (google), 2012-03-06 07:05:13]

http://codereview.chromium.org/9500002/diff/8007/runtime/bin/directory_impl.dart
File runtime/bin/directory_impl.dart (right):

http://codereview.chromium.org/9500002/diff/8007/runtime/bin/directory_impl.d...
runtime/bin/directory_impl.dart:89: _onError("Could not create temporary
directory [$_path]: " +
On 2012/02/29 15:42:20, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/9500002/diff/8007/runtime/bin/directory_impl.d...
runtime/bin/directory_impl.dart:108: void delete(bool recursive, void
callback()) {
On 2012/02/29 15:42:20, Søren Gjesse wrote:
> We should consider revising this to not take a boolean argument writing this
to
> delete a directory looks a bit strange:
> 
> d.delete(false, () => print("done"))
> d.delete(true, () => print("done"))
> 
> What is a "false" deletion of a directory?
> 
> How about
> 
> 
> d.delete(() => print("done"))
> d.deleteRecursive(() => print("done"))
> 
> or
> 
> 
> d.delete(DeleteMode.NON_RECURSIVE, () => print("done"))
> d.delete(DeleteMode.RECURSIVE, () => print("done"))

I have gone for two separate methods here. delete and deleteRecursively.

http://codereview.chromium.org/9500002/diff/8007/tests/standalone/src/Process...
File tests/standalone/src/ProcessTestUtil.dart (right):

http://codereview.chromium.org/9500002/diff/8007/tests/standalone/src/Process...
tests/standalone/src/ProcessTestUtil.dart:1: // Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
On 2012/02/29 15:42:20, Søren Gjesse wrote:
> No need to change this.

Done.