Issue 9500001: ui/gfx: Simplify RectToSkRect() implementation by using iset() function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9500001: ui/gfx: Simplify RectToSkRect() implementation by using iset() function. (Closed)

Created:
8 years, 9 months ago by tfarina

Modified:
8 years, 9 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ui/gfx: Simplify RectToSkRect() implementation by using iset() function. BUG=100898 R=pkasting@chromium.org TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124076

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	ui/gfx/skia_util.cc	View		2 chunks	+3 lines, -4 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tfarina

http://codereview.chromium.org/9500001/diff/1/ui/gfx/skia_util.cc File ui/gfx/skia_util.cc (right): http://codereview.chromium.org/9500001/diff/1/ui/gfx/skia_util.cc#newcode66 ui/gfx/skia_util.cc:66: string16 RemoveAcceleratorChar(const string16& s, Is there a better place ...

8 years, 9 months ago (2012-02-28 16:31:33 UTC) #1

Peter Kasting

8 years, 9 months ago (2012-02-28 19:18:22 UTC) #2

LGTM

http://codereview.chromium.org/9500001/diff/1/ui/gfx/skia_util.cc
File ui/gfx/skia_util.cc (right):

http://codereview.chromium.org/9500001/diff/1/ui/gfx/skia_util.cc#newcode66
ui/gfx/skia_util.cc:66: string16 RemoveAcceleratorChar(const string16& s,
On 2012/02/28 16:31:33, tfarina wrote:
> Is there a better place for this function?

I have no idea.  Don't know who uses it or who added it.  I agree with you that
it seems misplaced.

Expand Messages | Collapse Messages