Issue 9496003: AST extensions and parsing for import & export declarations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9496003: AST extensions and parsing for import & export declarations. (Closed)

Created:
8 years, 9 months ago by rossberg

Modified:
8 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

AST extensions and parsing for import & export declarations. R=jkummerow@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10866

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+340 lines, -41 lines)			Patch
M	src/ast.h	View	3 chunks	+59 lines, -0 lines	0 comments	Download
M	src/ast.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/full-codegen.cc	View	2 chunks	+18 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+11 lines, -1 line	0 comments	Download
M	src/parser.h	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	src/parser.cc	View	17 chunks	+148 lines, -32 lines	0 comments	Download
M	src/prettyprinter.cc	View	2 chunks	+29 lines, -0 lines	0 comments	Download
M	src/rewriter.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/mjsunit/harmony/module-parsing.js	View	2 chunks	+64 lines, -5 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 9 months ago (2012-02-28 14:04:09 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/9496003/diff/1/test/mjsunit/harmony/mo...
File test/mjsunit/harmony/module-parsing.js (right):

https://chromiumcodereview.appspot.com/9496003/diff/1/test/mjsunit/harmony/mo...
test/mjsunit/harmony/module-parsing.js:1: // Copyright 2011 the V8 project
authors. All rights reserved.
nit: 2012 :-)

Expand Messages | Collapse Messages