client/dom/scripts/systemnative.py - Issue 9495014: Support Dart optional arguments which are not dispatched, but instead use default values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/dom/scripts/systemnative.py

Issue 9495014: Support Dart optional arguments which are not dispatched, but instead use default values. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: forgotten : Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/dom/scripts/systemnative.py

diff --git a/client/dom/scripts/systemnative.py b/client/dom/scripts/systemnative.py

index ae75dbcd8e242f543647c188a025c78718820206..f6b580433a66514a61e190d0c9e5cafbaa158ae9 100644

--- a/client/dom/scripts/systemnative.py

+++ b/client/dom/scripts/systemnative.py

@@ -678,7 +678,7 @@ class NativeImplementationGenerator(systemwrapping.WrappingInterfaceGenerator):

self._cpp_impl_includes[include_name] = 1

flags = ''

if (idl_argument.ext_attrs.get('Optional') == 'DefaultIsNullString' or

- ('Optional' in idl_argument.ext_attrs and 'Callback' in idl_argument.ext_attrs)):

+ 'DartConvertNullToDefaultValue' in idl_argument.ext_attrs):

flags = ', DartUtilities::ConvertNullToDefaultValue'

emitter.Emit(

'\n'

« client/dom/scripts/databasebuilder.py ('K') | « client/dom/scripts/fremontcutbuilder.py ('k') | client/dom/scripts/systemwrapping.py » ('j') | client/dom/scripts/systemwrapping.py » ('J')