tools/json_schema_compiler/test/additionalProperties.json - Issue 9491002: json_schema_compiler: any, additionalProperties, functions on types

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/json_schema_compiler/test/additionalProperties.json

Issue 9491002: json_schema_compiler: any, additionalProperties, functions on types (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: remove whitespace Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« tools/json_schema_compiler/model.py ('K') | « tools/json_schema_compiler/model_test.py ('k') | tools/json_schema_compiler/test/additional_properties_unittest.cc » ('j') | tools/json_schema_compiler/test/additional_properties_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 [

	2 {

	3 "namespace": "additionalProperties",

	4 "types": [

	5 ],
	not at google - send to devlin 2012/02/29 03:06:30 seems unnecessary actually, what about additional seems unnecessary actually, what about additionalProperties in a type, didn't you support that...? though as I mentioned in previous comments, it seems surprising that you'd support it. calamity 2012/03/01 04:47:09 Done. Show quoted text On 2012/02/29 03:06:30, kalman wrote: > seems unnecessary > > actually, what about additionalProperties in a type, didn't you support that...? > though as I mentioned in previous comments, it seems surprising that you'd > support it. Done.
	6 "functions": [

	7 {

	8 "name": "additionalProperties",

	9 "type": "function",

	10 "description": "Takes an object with additionalProperties",

	11 "parameters": [

	12 {

	13 "name": "paramObject",

	14 "type": "object",

	15 "properties": {},

	16 "additionalProperties": {"type": "any"}

	17 }

	18 ]

	19 },

	20 {

	21 "name": "returnAdditionalProperties",

	22 "type": "function",

	23 "description": "Returns an object with additionalProperties.",

	24 "nodoc": "true",

	25 "parameters": [

	26 {

	27 "type": "function",

	28 "name": "callback",

	29 "parameters": [

	30 {

	31 "name": "resultObject",

	32 "type": "object",

	33 "properties": {

	34 "integer": {"type": "integer"}

	35 },

	36 "additionalProperties": {"type": "any"}

	37 }

	38 ]

	39 }

	40 ]

	41 }

	42 ]

	43 }

	44 ]

	45
	not at google - send to devlin 2012/02/29 03:06:30 some more things to test: (and in C++) - more than some more things to test: (and in C++) - more than one property, only setting one of them (should error) - setting a property to something wrong (like int property set to string, should error) just to make sure that additionalProperties doesn't interfere with the error checking. calamity 2012/03/01 04:47:09 Done. Show quoted text On 2012/02/29 03:06:30, kalman wrote: > some more things to test: (and in C++) > - more than one property, only setting one of them (should error) > - setting a property to something wrong (like int property set to string, should > error) > > just to make sure that additionalProperties doesn't interfere with the error > checking. Done.
	46

OLD	NEW