Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: src/ast.h

Issue 9490009: Thread isolate through Property constructor, avoiding Isolate::Current. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ast.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1239 matching lines...) Expand 10 before | Expand all | Expand 10 after
1250 class Property: public ZoneObject { 1250 class Property: public ZoneObject {
1251 public: 1251 public:
1252 enum Kind { 1252 enum Kind {
1253 CONSTANT, // Property with constant value (compile time). 1253 CONSTANT, // Property with constant value (compile time).
1254 COMPUTED, // Property with computed value (execution time). 1254 COMPUTED, // Property with computed value (execution time).
1255 MATERIALIZED_LITERAL, // Property value is a materialized literal. 1255 MATERIALIZED_LITERAL, // Property value is a materialized literal.
1256 GETTER, SETTER, // Property is an accessor function. 1256 GETTER, SETTER, // Property is an accessor function.
1257 PROTOTYPE // Property is __proto__. 1257 PROTOTYPE // Property is __proto__.
1258 }; 1258 };
1259 1259
1260 Property(Literal* key, Expression* value); 1260 Property(Literal* key, Expression* value, Isolate* isolate);
1261 1261
1262 Literal* key() { return key_; } 1262 Literal* key() { return key_; }
1263 Expression* value() { return value_; } 1263 Expression* value() { return value_; }
1264 Kind kind() { return kind_; } 1264 Kind kind() { return kind_; }
1265 1265
1266 bool IsCompileTimeValue(); 1266 bool IsCompileTimeValue();
1267 1267
1268 void set_emit_store(bool emit_store); 1268 void set_emit_store(bool emit_store);
1269 bool emit_store(); 1269 bool emit_store();
1270 1270
(...skipping 1602 matching lines...) Expand 10 before | Expand all | Expand 10 after
2873 private: 2873 private:
2874 Isolate* isolate_; 2874 Isolate* isolate_;
2875 Zone* zone_; 2875 Zone* zone_;
2876 Visitor visitor_; 2876 Visitor visitor_;
2877 }; 2877 };
2878 2878
2879 2879
2880 } } // namespace v8::internal 2880 } } // namespace v8::internal
2881 2881
2882 #endif // V8_AST_H_ 2882 #endif // V8_AST_H_
OLDNEW
« no previous file with comments | « no previous file | src/ast.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698