Fix illegal escape-sequences to throw syntax errors.

test/mjsunit/compiler/literals.js

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 18 matching lines @@
 assertEquals(8, eval("8"));
 
 assertEquals(null, eval("null"));
 
 assertEquals("abc", eval("'abc'"));
 
 assertEquals(8, eval("6;'abc';8"));
 
 // Characters just outside the ranges of hex-escapes.
 // "/" comes just before "0".
-assertEquals("x1/", "\x1/");
-assertEquals("u111/", "\u111/");
+assertThrows('"\\x1/"');
+assertThrows('"\\u111/"');
 assertEquals("\\x1/", RegExp("\\x1/").source);
 assertEquals("\\u111/", RegExp("\\u111/").source);
 
 // ":" comes just after "9".
-assertEquals("x1:", "\x1:");
-assertEquals("u111:", "\u111:");
+assertThrows('"\\x1:"');
+assertThrows('"\\u111:"');
 assertEquals("\\x1:", /\x1:/.source);
 assertEquals("\\u111:", /\u111:/.source);
 
 // "`" comes just before "a".
-assertEquals("x1`", "\x1`");
-assertEquals("u111`", "\u111`");
+assertThrows('"\\x1`"');
+assertThrows('"\\u111`"');
 assertEquals("\\x1`", /\x1`/.source);
 assertEquals("\\u111`", /\u111`/.source);
 
 // "g" comes just before "f".
-assertEquals("x1g", "\x1g");
-assertEquals("u111g", "\u111g");
+assertThrows('"\\x1g"');
+assertThrows('"\\u111g"');
 assertEquals("\\x1g", /\x1g/.source);
 assertEquals("\\u111g", /\u111g/.source);
 
 // "@" comes just before "A".
-assertEquals("x1@", "\x1@");
-assertEquals("u111@", "\u111@");
+assertThrows('"\\x1@"');
+assertThrows('"\\u111@"');
 assertEquals("\\x1@", /\x1@/.source);
 assertEquals("\\u111@", /\u111@/.source);
 
 // "G" comes just after "F".
-assertEquals("x1G", "\x1G");
-assertEquals("u111G", "\u111G");
+assertThrows('"\\x1G"');
+assertThrows('"\\u111G"');

[Erik Corry, 2012/04/16 14:16:32]

You are sure this matches the other browsers?

[Michael Starzinger, 2012/04/16 15:44:37]

As discussed offline, Firefox stable (i.e. tested FF9 on Mac and FF11 on Linux)
matches this behavior. Safari stable only partially matches this behavior, but
nightly versions of JSC do match. Opera 11.60 also matches this behavior.

[Michael Starzinger, 2012/04/16 15:53:23]

For the sake of completeness, IE9 also matches this behavior.

 assertEquals("\\x1G", /\x1G/.source);
 assertEquals("\\u111G", /\u111G/.source);
 
 // Test some materialized array literals.
 assertEquals([1,2,3,4], eval('[1,2,3,4]'));
 assertEquals([[1,2],3,4], eval('[[1,2],3,4]'));
 assertEquals([1,[2,3,4]], eval('[1,[2,3,4]]'));
 
 assertEquals([1,2,3,4], eval('var a=1, b=2; [a,b,3,4]'))
 assertEquals([1,2,3,4], eval('var a=1, b=2, c = [a,b,3,4]; c'));
 
 function double(x) { return x + x; }
 var s = 'var a = 1, b = 2; [double(a), double(b), double(3), double(4)]';
 assertEquals([2,4,6,8], eval(s));
 
 // Test array literals in effect context.
 assertEquals(17, eval('[1,2,3,4]; 17'));
 assertEquals(19, eval('var a=1, b=2; [a,b,3,4]; 19'));
 assertEquals(23, eval('var a=1, b=2; c=23; [a,b,3,4]; c'));
 
 // Test that literals work for non-smi indices.
 // Ensure hash-map collision if using value as hash.
 var o = {"2345678901" : 42, "2345678901" : 30};