Fix illegal escape-sequences to throw syntax errors.

Fix illegal escape-sequences to throw syntax errors.

R=erik.corry@gmail.com
TEST=test262/S7.8.4_A6.*,test262/S7.8.4_A7.*

Committed: https://code.google.com/p/v8/source/detail?r=11340

[Erik Corry, 2012-04-16 14:16:32]

LGTM

https://chromiumcodereview.appspot.com/9490006/diff/1001/src/scanner.cc
File src/scanner.cc (right):

https://chromiumcodereview.appspot.com/9490006/diff/1001/src/scanner.cc#newco...
src/scanner.cc:657: // According to ECMA-262, 3rd, 7.8.4 (p 18ff) these
Comment still up to date?  Should say 5th edition at least.

https://chromiumcodereview.appspot.com/9490006/diff/1001/src/scanner.h
File src/scanner.h (right):

https://chromiumcodereview.appspot.com/9490006/diff/1001/src/scanner.h#newcod...
src/scanner.h:532: // Scans a uniocde escape-sequence and adds its characters,
uniocde -> Unicode
(not just the capitalization)

https://chromiumcodereview.appspot.com/9490006/diff/1001/test/mjsunit/compile...
File test/mjsunit/compiler/literals.js (right):

https://chromiumcodereview.appspot.com/9490006/diff/1001/test/mjsunit/compile...
test/mjsunit/compiler/literals.js:70: assertThrows('"\\u111G"');
You are sure this matches the other browsers?

[Michael Starzinger, 2012-04-16 15:44:37]

Added new patch set.

https://chromiumcodereview.appspot.com/9490006/diff/1001/src/scanner.cc
File src/scanner.cc (right):

https://chromiumcodereview.appspot.com/9490006/diff/1001/src/scanner.cc#newco...
src/scanner.cc:657: // According to ECMA-262, 3rd, 7.8.4 (p 18ff) these
On 2012/04/16 14:16:32, Erik Corry wrote:
> Comment still up to date?  Should say 5th edition at least.

Done.

https://chromiumcodereview.appspot.com/9490006/diff/1001/src/scanner.h
File src/scanner.h (right):

https://chromiumcodereview.appspot.com/9490006/diff/1001/src/scanner.h#newcod...
src/scanner.h:532: // Scans a uniocde escape-sequence and adds its characters,
On 2012/04/16 14:16:32, Erik Corry wrote:
> uniocde -> Unicode
> (not just the capitalization)

Done.

https://chromiumcodereview.appspot.com/9490006/diff/1001/test/mjsunit/compile...
File test/mjsunit/compiler/literals.js (right):

https://chromiumcodereview.appspot.com/9490006/diff/1001/test/mjsunit/compile...
test/mjsunit/compiler/literals.js:70: assertThrows('"\\u111G"');
On 2012/04/16 14:16:32, Erik Corry wrote:
> You are sure this matches the other browsers?

As discussed offline, Firefox stable (i.e. tested FF9 on Mac and FF11 on Linux)
matches this behavior. Safari stable only partially matches this behavior, but
nightly versions of JSC do match. Opera 11.60 also matches this behavior.

[Michael Starzinger, 2012-04-16 15:53:22]

https://chromiumcodereview.appspot.com/9490006/diff/1001/test/mjsunit/compile...
File test/mjsunit/compiler/literals.js (right):

https://chromiumcodereview.appspot.com/9490006/diff/1001/test/mjsunit/compile...
test/mjsunit/compiler/literals.js:70: assertThrows('"\\u111G"');
On 2012/04/16 15:44:37, Michael Starzinger wrote:
> On 2012/04/16 14:16:32, Erik Corry wrote:
> > You are sure this matches the other browsers?

For the sake of completeness, IE9 also matches this behavior.