Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 9490004: Thread the current isolate through a few places, avoiding Isolate::Current(). (Closed)

Created:
8 years, 9 months ago by Sven Panne
Modified:
8 years, 9 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Thread the current isolate through a few places, avoiding Isolate::Current(). This removes approx. 12k calls of Isolate::Current() in string-tagcloud. Committed: https://code.google.com/p/v8/source/detail?r=10856

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
M src/arm/regexp-macro-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/execution.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/execution.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/jsregexp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/jsregexp.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M src/mips/regexp-macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years, 9 months ago (2012-02-28 10:16:35 UTC) #1
fschneider
8 years, 9 months ago (2012-02-28 10:22:47 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698