Elide long emails in the wrench and profile menus.

ui/base/text/text_elider_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Unit tests for eliding and formatting utility functions.
 
 #include "ui/base/text/text_elider.h"
 
 #include "base/file_path.h"
 #include "base/i18n/rtl.h"
@@ skipping 35 matching lines @@
     const GURL url(testcases[i].input);
     // Should we test with non-empty language list?
     // That's kinda redundant with net_util_unittests.
     EXPECT_EQ(UTF8ToUTF16(testcases[i].output),
               ElideUrl(url, font,
                        font.GetStringWidth(UTF8ToUTF16(testcases[i].output)),
                        std::string()));
   }
 }
 
+void RunEmailTest(Testcase* testcases, size_t num_testcases,

[Alexei Svitkine (slow), 2012/02/28 15:46:22]

Nit: Put "num_testcases" on its own line.

+                  size_t max_email_length) {
+  for (size_t i = 0; i < num_testcases; ++i) {
+    EXPECT_EQ(UTF8ToUTF16(testcases[i].output),
+              ElideEmail(UTF8ToUTF16(testcases[i].input), max_email_length));
+  }
+}
+
 }  // namespace
 
+TEST(TextEliderTest, SmallestElideEmail) {
+  const std::string kEllipsisStr(kEllipsis);
+
+  // all expected values in this test assume the UTF16 ellipsis is a single char
+  ASSERT_EQ(UTF8ToUTF16(kEllipsisStr).length(), size_t(1));
+
+  // 5 is the smallest max_email_length allowed in ui::ElideEmail
+  const size_t max_email_length = 5;
+
+  Testcase testcases[] = {
+      {"g@g.c", "g@g.c"},
+      {"ga@co", "ga@co"},
+      {"short@small.com", "s" + kEllipsisStr + "@s" +kEllipsisStr},

[Alexei Svitkine (slow), 2012/02/28 15:46:22]

Add a space between + and kEllipsisStr.

+  };
+
+  RunEmailTest(testcases, arraysize(testcases), max_email_length);
+}
+
+TEST(TextEliderTest, RegularElideEmail) {
+  const std::string kEllipsisStr(kEllipsis);
+
+  // all expected values in this test assume the UTF16 ellipsis is a single char

[Alexei Svitkine (slow), 2012/02/28 15:46:22]

Comments should be complete sentences: starting with a capital and ending with a
period.

+  ASSERT_EQ(UTF8ToUTF16(kEllipsisStr).length(), size_t(1));
+
+  const size_t max_email_length = 20;
+
+  Testcase testcases[] = {
+      {"short@small.com", "short@small.com"},
+      {"justunder@test19.ca", "justunder@test19.ca"},
+      {"exactly@righton20.ca", "exactly@righton20.ca"},
+      {"justover20@test21.com", "justover" + kEllipsisStr + "@test21.com"},
+      {"longusernameshortdomain@short.com", "longusern" + kEllipsisStr +
+                                            "@short.com"},
+      {"short@verysuperlongdomain.com", "short@verys" + kEllipsisStr + ".com"},
+      {"waytoobigofanemail@somealsoverybigdomain.com", "waytoobi" +
+                                                       kEllipsisStr  +
+                                                       "@somea" +
+                                                       kEllipsisStr +
+                                                       ".com"},
+      {"toolongusername@maxsizedomain.com", "t" + kEllipsisStr +
+                                            "@maxsizedomain.com"},
+      {"toolongusername@justovermaxof17.tv", "toolongu" + kEllipsisStr +
+                                             "@justo" + kEllipsisStr +
+                                             "7.tv"},
+  };
+
+  RunEmailTest(testcases, arraysize(testcases), max_email_length);
+}
+
 // Test eliding of commonplace URLs.
 TEST(TextEliderTest, TestGeneralEliding) {
   const std::string kEllipsisStr(kEllipsis);
   Testcase testcases[] = {
     {"http://www.google.com/intl/en/ads/",
      "www.google.com/intl/en/ads/"},
     {"http://www.google.com/intl/en/ads/", "www.google.com/intl/en/ads/"},
     {"http://www.google.com/intl/en/ads/",
      "google.com/intl/" + kEllipsisStr + "/ads/"},
     {"http://www.google.com/intl/en/ads/",
@@ skipping 712 matching lines @@
 
   // Test adds ... at right spot when there is not enough room to break at a
   // word boundary.
   EXPECT_EQ(L"foooooey\x2026", UTF16ToWide(TruncateString(string, 11)));
 
   // Test completely truncates string if break is on initial whitespace.
   EXPECT_EQ(L"\x2026", UTF16ToWide(TruncateString(ASCIIToUTF16("   "), 2)));
 }
 
 }  // namespace ui