Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 9489008: Fix error introduced when renaming variable in test_suite.dart, in r4671. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 712 matching lines...) Expand 10 before | Expand all | Expand 10 after
723 List<String> dartOptions = optionsFromFile["dartOptions"]; 723 List<String> dartOptions = optionsFromFile["dartOptions"];
724 List<List<String>> vmOptionsList = optionsFromFile["vmOptions"]; 724 List<List<String>> vmOptionsList = optionsFromFile["vmOptions"];
725 Expect.isTrue(!isMultitest || dartOptions == null); 725 Expect.isTrue(!isMultitest || dartOptions == null);
726 if (dartOptions == null) { 726 if (dartOptions == null) {
727 args.add(filename); 727 args.add(filename);
728 } else { 728 } else {
729 var executable_name = dartOptions[0]; 729 var executable_name = dartOptions[0];
730 // TODO(ager): Get rid of this hack when the runtime checkout goes away. 730 // TODO(ager): Get rid of this hack when the runtime checkout goes away.
731 var file = new File(executable_name); 731 var file = new File(executable_name);
732 if (!file.existsSync()) { 732 if (!file.existsSync()) {
733 executable_name = '../$filename'; 733 executable_name = '../$executable_name';
734 Expect.isTrue(new File(executable_name).existsSync()); 734 Expect.isTrue(new File(executable_name).existsSync());
735 dartOptions[0] = executable_name; 735 dartOptions[0] = executable_name;
736 } 736 }
737 args.addAll(dartOptions); 737 args.addAll(dartOptions);
738 } 738 }
739 739
740 var result = new List<List<String>>(); 740 var result = new List<List<String>>();
741 Expect.isFalse(vmOptionsList.isEmpty(), "empty vmOptionsList"); 741 Expect.isFalse(vmOptionsList.isEmpty(), "empty vmOptionsList");
742 for (var vmOptions in vmOptionsList) { 742 for (var vmOptions in vmOptionsList) {
743 var options = new List<String>.from(vmOptions); 743 var options = new List<String>.from(vmOptions);
(...skipping 398 matching lines...) Expand 10 before | Expand all | Expand 10 after
1142 * $noCrash tests are expected to be flaky but not crash 1142 * $noCrash tests are expected to be flaky but not crash
1143 * $pass tests are expected to pass 1143 * $pass tests are expected to pass
1144 * $failOk tests are expected to fail that we won't fix 1144 * $failOk tests are expected to fail that we won't fix
1145 * $fail tests are expected to fail that we should fix 1145 * $fail tests are expected to fail that we should fix
1146 * $crash tests are expected to crash that we should fix 1146 * $crash tests are expected to crash that we should fix
1147 * $timeout tests are allowed to timeout 1147 * $timeout tests are allowed to timeout
1148 """; 1148 """;
1149 print(report); 1149 print(report);
1150 } 1150 }
1151 } 1151 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698