aura: Fix popup window positioning.

content/browser/renderer_host/render_widget_host_view_aura.cc

Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 8ff2a0b3f838ca0a253ac6b95f0d9d2e0c76aca4..cb6814f1090003651581901f17614dc04889ff7f 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -174,14 +174,7 @@ void RenderWidgetHostViewAura::InitAsPopup(
 
   window_->SetParent(NULL);
   Show();
-
-  // |pos| is in root window coordinates. So convert it to
-  // |popup_parent_host_view_|'s coordinates first.
-  gfx::Point origin = pos.origin();
-  aura::Window::ConvertPointToWindow(
-      window_->GetRootWindow(),
-      popup_parent_host_view_->window_, &origin);
-  SetBounds(gfx::Rect(origin, pos.size()));
+  SetBounds(gfx::Rect(pos.origin(), pos.size()));

[Daniel Erat, 2012/02/28 17:41:04]

why are you creating a new gfx::Rect here instead of just passing |pos|?

also, it's probably better to set the bounds before calling Show(), assuming
there aren't any issues with doing that.

[tfarina, 2012/02/28 18:08:30]

if |pos| is-a gfx::Rect, why are you creating another rect, instead of passing
|pos| directly to SetBounds?

[yoshiki, 2012/02/29 08:37:28]

Done.

 }
 
 void RenderWidgetHostViewAura::InitAsFullscreen(
@@ -214,18 +207,6 @@ void RenderWidgetHostViewAura::SetSize(const gfx::Size& size) {
 
 void RenderWidgetHostViewAura::SetBounds(const gfx::Rect& rect) {
   gfx::Rect adjusted_rect = rect;
-
-  if (popup_parent_host_view_) {
-    gfx::Point translated_origin = adjusted_rect.origin();
-    // |rect| is relative to |popup_parent_host_view_|; translate it for the
-    // window's container.
-    aura::Window::ConvertPointToWindow(
-        popup_parent_host_view_->window_,
-        window_->parent(),
-        &translated_origin);
-    adjusted_rect.set_origin(translated_origin);
-  }
-
   window_->SetBounds(adjusted_rect);
   host_->WasResized();
 }