Cleanup: Deprecate wstring version of file_util::CopyDirectory().

Cleanup: Deprecate wstring version of file_util::CopyDirectory().

BUG=24672
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124819

[Lei Zhang, 2012-03-02 03:06:39]

http://codereview.chromium.org/9484003/diff/30001/base/file_util.cc
File base/file_util.cc (left):

http://codereview.chromium.org/9484003/diff/30001/base/file_util.cc#oldcode403
base/file_util.cc:403: bool Delete(const std::wstring& path, bool recursive) {
This should have been deleted in an earlier CL, whoops.

[brettw, 2012-03-02 05:32:45]

lgtm

[Lei Zhang, 2012-03-02 06:27:57]

pkasting: OWNERS review for select_file_dialog_win.cc.

[Peter Kasting, 2012-03-02 18:11:58]

LGTM

http://codereview.chromium.org/9484003/diff/30001/chrome/browser/ui/views/sel...
File chrome/browser/ui/views/select_file_dialog_win.cc (right):

http://codereview.chromium.org/9484003/diff/30001/chrome/browser/ui/views/sel...
chrome/browser/ui/views/select_file_dialog_win.cc:36: size_t len =
extension.length();
Nit: Simpler:

  DCHECK(extension.empty() || extension[0] == L'.');
  return extension.empty() ? extension : extension.substr(1);

http://codereview.chromium.org/9484003/diff/30001/chrome/browser/ui/views/sel...
chrome/browser/ui/views/select_file_dialog_win.cc:67: if (key.empty())
Nit: This can be omitted, GetExtensionWithoutLeadingDot() will work fine without
it.

Then |key| can be inlined into the creation of |file_extension| below.

[Lei Zhang, 2012-03-02 22:54:32]

http://codereview.chromium.org/9484003/diff/30001/chrome/browser/ui/views/sel...
File chrome/browser/ui/views/select_file_dialog_win.cc (right):

http://codereview.chromium.org/9484003/diff/30001/chrome/browser/ui/views/sel...
chrome/browser/ui/views/select_file_dialog_win.cc:36: size_t len =
extension.length();
On 2012/03/02 18:11:58, Peter Kasting wrote:
> Nit: Simpler:
> 
>   DCHECK(extension.empty() || extension[0] == L'.');
>   return extension.empty() ? extension : extension.substr(1);

Done.

http://codereview.chromium.org/9484003/diff/30001/chrome/browser/ui/views/sel...
chrome/browser/ui/views/select_file_dialog_win.cc:67: if (key.empty())
On 2012/03/02 18:11:58, Peter Kasting wrote:
> Nit: This can be omitted, GetExtensionWithoutLeadingDot() will work fine
without
> it.
> 
> Then |key| can be inlined into the creation of |file_extension| below.

Done.

[commit-bot: I haz the power, 2012-03-02 22:55:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/9484003/42001

[commit-bot: I haz the power, 2012-03-02 22:55:03]

Presubmit check for 9484003-42001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling an API that accepts a
wstring, fix the API.
    chrome/browser/ui/views/select_file_dialog_win.cc:35
    chrome/browser/ui/views/select_file_dialog_win.cc:63
    chrome/browser/ui/views/select_file_dialog_win.cc:259

Presubmit checks took 1.2s to calculate.