Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 9481015: Make the PPP wrappers take an Instance*. (Closed)

Created:
8 years, 10 months ago by brettw
Modified:
8 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews
Visibility:
Public.

Description

Make the PPP wrappers take an Instance*. I changed these to take InstanceHandles but this doesn't actually work. If you use them the recommended way, the module->instance mapping isn't set up by the time the constructors are called, so doing AddPerInstanceObject fails. Since these objects are all called on the main thread, there is no race condition with pp::Instance destruction and the implementation using a pointer is safe. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123828

Patch Set 1 #

Patch Set 2 : USELESS PATCH DESCRIPTION #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -49 lines) Patch
M ppapi/cpp/dev/find_dev.h View 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/cpp/dev/find_dev.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ppapi/cpp/dev/printing_dev.h View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/cpp/dev/printing_dev.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/cpp/dev/selection_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/cpp/dev/selection_dev.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/cpp/dev/video_capture_client_dev.h View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/cpp/dev/video_capture_client_dev.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/cpp/dev/video_decoder_client_dev.h View 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/cpp/dev/video_decoder_client_dev.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/cpp/dev/widget_client_dev.h View 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/cpp/dev/widget_client_dev.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/cpp/dev/zoom_dev.h View 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/cpp/dev/zoom_dev.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ppapi/cpp/graphics_3d_client.h View 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/cpp/graphics_3d_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/cpp/instance.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ppapi/cpp/instance.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M ppapi/cpp/mouse_lock.h View 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/cpp/mouse_lock.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
8 years, 10 months ago (2012-02-27 21:55:58 UTC) #1
jam
lgtm
8 years, 10 months ago (2012-02-27 21:57:01 UTC) #2
jam
in debug builds when navigating away from a pdf, i hit PP_DCHECK(interface_name_to_objects_.empty()); there are 6 ...
8 years, 10 months ago (2012-02-28 00:41:54 UTC) #3
brettw
8 years, 10 months ago (2012-02-28 04:47:23 UTC) #4
On Mon, Feb 27, 2012 at 4:41 PM, John Abd-El-Malek <jam@chromium.org> wrote:
> in debug builds when navigating away from a pdf, i hit
>
> PP_DCHECK(interface_name_to_objects_.empty());
>
> there are 6 interfaces in that map

Thanks, I'll fix that. It should be harmless in the meantime.

Brett

Powered by Google App Engine
This is Rietveld 408576698