Issue 9480022: Revert 123894 - Remove hand-rolled protobufs generation; enable rel paths in protoc.gypi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9480022: Revert 123894 - Remove hand-rolled protobufs generation; enable rel paths in protoc.gypi (Closed)

Created:
8 years, 9 months ago by Ryan Sleevi

Modified:
8 years, 9 months ago

Reviewers:
KushalP

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 123894 - Remove hand-rolled protobufs generation; enable rel paths in protoc.gypi protoc.gypi now accepts a relative path to handle the way that protoc_out_dir is applied to build the generated path. Remove the 'cacheinvalidation_proto_cpp' target and instead generate a static_library to begin with. Simplify all steps by removing the actions and including the protoc.gypi file. BUG=113339 Review URL: http://codereview.chromium.org/9378041 TBR=kushi.p@gmail.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123896

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -37 lines)			Patch
	M	build/protoc.gypi	View		4 chunks	+6 lines, -23 lines	0 comments	Download
	M	third_party/cacheinvalidation/cacheinvalidation.gyp	View		4 chunks	+72 lines, -14 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages