Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 9480019: Adding webdriver setup script. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 4633)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -558,6 +558,7 @@
* used.
*/
String browserUsed;
+ Process selenium_server;
ProcessQueue(int this._maxProcesses,
String progress,
@@ -575,6 +576,7 @@
_testCache = new Map<String, List<TestInformation>>() {
if (!_enqueueMoreWork(this)) _progress.allDone();
browserUsed = '';
+ selenium_server = null;
}
/**
@@ -650,6 +652,9 @@
void _cleanupAndMarkDone() {
if (browserUsed != '') {
killZombieBrowsers();
+ if (selenium_server != null) {
+ selenium_server.close();
+ }
} else {
_progress.allDone();
}
@@ -692,6 +697,9 @@
void _runTest(TestCase test) {
if (test.configuration['component'] == 'webdriver') {
browserUsed = test.configuration['browser'];
+ if (new Platform().operatingSystem() == 'mac') {
+ selenium_server = new Process.start('java', ['-jar', ]);//TODO(efortuna)
Emily Fortuna 2012/02/28 07:06:51 This section isn't done (I need to find the correc
Jennifer Messerly 2012/02/28 16:56:56 maybe require it to be downloaded to a particular
Emily Fortuna 2012/02/29 01:10:34 Yes, I will have it downloaded in a particular loc
+ }
}
_progress.testAdded();
_tests.add(test);

Powered by Google App Engine
This is Rietveld 408576698