Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 9480016: Fix memory leak in SequencedWorkerPool (Closed)

Created:
8 years, 9 months ago by akalin
Modified:
8 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Fix memory leak in SequencedWorkerPool The leak was due to a cyclic reference from SequencedWorkerPool::Worker. BUG=115987 TEST= TBR=brettw Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124097

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments, add suppression removal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -44 lines) Patch
M base/threading/sequenced_worker_pool.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
M tools/valgrind/drmemory/suppressions_full.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +1 line, -8 lines 0 comments Download
M tools/valgrind/memcheck/suppressions_mac.txt View 1 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
akalin
+brettw for review
8 years, 9 months ago (2012-02-28 01:45:34 UTC) #1
brettw
https://chromiumcodereview.appspot.com/9480016/diff/1/base/threading/sequenced_worker_pool.cc File base/threading/sequenced_worker_pool.cc (right): https://chromiumcodereview.appspot.com/9480016/diff/1/base/threading/sequenced_worker_pool.cc#newcode49 base/threading/sequenced_worker_pool.cc:49: // around as long as we are running. Note ...
8 years, 9 months ago (2012-02-28 04:38:45 UTC) #2
akalin
PTAL http://codereview.chromium.org/9480016/diff/1/base/threading/sequenced_worker_pool.cc File base/threading/sequenced_worker_pool.cc (right): http://codereview.chromium.org/9480016/diff/1/base/threading/sequenced_worker_pool.cc#newcode49 base/threading/sequenced_worker_pool.cc:49: // around as long as we are running. ...
8 years, 9 months ago (2012-02-28 22:10:33 UTC) #3
akalin
I'm just going to TBR this, to save memory sheriffs the trouble of widening the ...
8 years, 9 months ago (2012-02-29 02:30:53 UTC) #4
akalin
8 years, 9 months ago (2012-02-29 02:31:08 UTC) #5
if you have further comments, i can address them in another CL

Powered by Google App Engine
This is Rietveld 408576698