Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: runtime/vm/stack_frame.h

Issue 9480006: Fix issue 1857: code lookup was wrong when searching for exception handler. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/stack_frame.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_STACK_FRAME_H_ 5 #ifndef VM_STACK_FRAME_H_
6 #define VM_STACK_FRAME_H_ 6 #define VM_STACK_FRAME_H_
7 7
8 #include "vm/allocation.h" 8 #include "vm/allocation.h"
9 #include "vm/object.h" 9 #include "vm/object.h"
10 #include "vm/stub_code.h" 10 #include "vm/stub_code.h"
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 public: 125 public:
126 bool IsValid() const { return (LookupDartFunction() != Function::null()); } 126 bool IsValid() const { return (LookupDartFunction() != Function::null()); }
127 bool IsDartFrame() const { return true; } 127 bool IsDartFrame() const { return true; }
128 128
129 // Visit objects in the frame. 129 // Visit objects in the frame.
130 virtual void VisitObjectPointers(ObjectPointerVisitor* visitor); 130 virtual void VisitObjectPointers(ObjectPointerVisitor* visitor);
131 131
132 // Get function object corresponding to pc for the frame. 132 // Get function object corresponding to pc for the frame.
133 RawFunction* LookupDartFunction() const; 133 RawFunction* LookupDartFunction() const;
134 134
135 // Get code object corresponding to pc for the frame.
136 RawCode* LookupDartCode() const;
137
135 // Find exception handler pc in frame if one exists. 138 // Find exception handler pc in frame if one exists.
136 bool FindExceptionHandler(uword* handler_pc) const; 139 bool FindExceptionHandler(uword* handler_pc) const;
137 140
138 protected: 141 protected:
139 virtual const char* GetName() const { return "dart"; } 142 virtual const char* GetName() const { return "dart"; }
140 143
141 private: 144 private:
142 DartFrame() { } 145 DartFrame() { }
143 146
144 friend class StackFrameIterator; 147 friend class StackFrameIterator;
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 258
256 private: 259 private:
257 StackFrameIterator frames_; 260 StackFrameIterator frames_;
258 261
259 DISALLOW_COPY_AND_ASSIGN(DartFrameIterator); 262 DISALLOW_COPY_AND_ASSIGN(DartFrameIterator);
260 }; 263 };
261 264
262 } // namespace dart 265 } // namespace dart
263 266
264 #endif // VM_STACK_FRAME_H_ 267 #endif // VM_STACK_FRAME_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/stack_frame.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698