Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(144)

Issue 9479030: Merge 108724 - Don't clear IntentRequest callback pointers on stop() (Closed)

Created:
8 years, 11 months ago by bashi
Modified:
8 years, 11 months ago
Reviewers:
gbillock
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Merge 108724 - Don't clear IntentRequest callback pointers on stop() This causes re-entry into ScriptExecutionContext when the ActiveDOMCallback objects get deleted, which crashes. Instead, just de-activate the object and wait for context destruction to clean up. Test crashes consistently without fix and passes with fix. Added some test infrastructure to support this test. https://bugs.webkit.org/show_bug.cgi?id=78638 Patch by Greg Billock <gbillock@google.com>; on 2012-02-23 Reviewed by Adam Barth. * Modules/intents/IntentRequest.cpp: (WebCore::IntentRequest::IntentRequest): (WebCore::IntentRequest::stop): (WebCore::IntentRequest::postResult): (WebCore::IntentRequest::postFailure): * Modules/intents/IntentRequest.h: (IntentRequest): TBR=gbillock@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=109044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
A + LayoutTests/webintents/web-intents-reload.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/webintents/web-intents-reload-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/Modules/intents/IntentRequest.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/Modules/intents/IntentRequest.cpp View 2 chunks +9 lines, -4 lines 0 comments Download
M Tools/DumpRenderTree/chromium/WebViewHost.h View 3 chunks +5 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/WebViewHost.cpp View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bashi
8 years, 11 months ago (2012-02-28 01:09:31 UTC) #1
Greg Billock
8 years, 11 months ago (2012-02-28 18:27:42 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698