Issue 9479029: content: Make use of gfx::RectToSkRect() to simplify two SkRect initializations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9479029: content: Make use of gfx::RectToSkRect() to simplify two SkRect initializations. (Closed)

Created:
8 years, 10 months ago by tfarina

Modified:
8 years, 9 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

content: Make use of gfx::RectToSkRect() to simplify two SkRect initializations. R=pkasting@chromium.org TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123968

Patch Set 2 : inline #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	content/renderer/render_widget.cc	View	1	3 chunks	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

LGTM http://codereview.chromium.org/9479029/diff/1/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): http://codereview.chromium.org/9479029/diff/1/content/renderer/render_widget.cc#newcode617 content/renderer/render_widget.cc:617: SkRect clip(gfx::RectToSkRect(rect)); Nit: Can we just inline this ...

8 years, 10 months ago (2012-02-28 05:52:08 UTC) #2

tfarina

8 years, 9 months ago (2012-02-28 13:12:25 UTC) #3

http://codereview.chromium.org/9479029/diff/1/content/renderer/render_widget.cc
File content/renderer/render_widget.cc (right):

http://codereview.chromium.org/9479029/diff/1/content/renderer/render_widget....
content/renderer/render_widget.cc:617: SkRect clip(gfx::RectToSkRect(rect));
On 2012/02/28 05:52:08, Peter Kasting wrote:
> Nit: Can we just inline this into the next line?

Done.

Expand Messages | Collapse Messages

Issue 9479029: content: Make use of gfx::RectToSkRect() to simplify two SkRect initializations. (Closed)

Description

Patch Set 1 #

Patch Set 2 : inline #

Messages