Issue 9479009: roll gtm 459:516

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9479009: roll gtm 459:516 (Closed)

Created:
8 years, 10 months ago by Nico

Modified:
8 years, 10 months ago

Reviewers:
TVL

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

roll gtm 459:516 This is to pick up r516, a clang warning fix. Most changes in the roll are iOS or test-related and shouldn't affect chrome. Interesting changes: r465 changed an API ( http://code.google.com/p/google-toolbox-for-mac/source/detail?r=465 ) r471-473: GTMUILocalizer change. BUG=115847 TEST=remoting_host builds with the 10.6 sdk. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123819

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/common/mac/launchd.mm	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

TVL

fyi - Some of those changes you mentioned are the iOS version of the localizer.

8 years, 10 months ago (2012-02-27 18:09:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9479009/1

8 years, 10 months ago (2012-02-27 18:13:30 UTC) #4

Nico

I had to change launchd.mm for an upstream api change, too.

8 years, 10 months ago (2012-02-27 19:24:05 UTC) #5

commit-bot: I haz the power

8 years, 10 months ago (2012-02-27 19:24:19 UTC) #6

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/9479009/5002