Allow to override the location of ASan blacklist.

Allow to override the location of ASan blacklist.
This is needed to build a CrOS binary, because the buildsystem doesn't play well with relative paths.

BUG=chromium-os:26919
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123935

[Alexander Potapenko, 2012-02-27 15:38:37]

Nico, can you please take a look?
Denis, FYI

[Nico, 2012-02-27 15:41:27]

Can you file a big that explains the cros build issue and add it to the
bug= line?
On Feb 27, 2012 7:38 AM, <glider@chromium.org> wrote:

> Reviewers: Nico,
>
> Message:
> Nico, can you please take a look?
> Denis, FYI
>
> Description:
> Allow to override the location of ASan blacklist.
> This is needed to build a CrOS binary, because the buildsystem doesn't
> play well
> with relative paths.
>
> Please review this at
https://chromiumcodereview.**appspot.com/9479002/<https://chromiumcodereview....
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     build/common.gypi
>
>
> Index: build/common.gypi
> ==============================**==============================**=======
> --- build/common.gypi   (revision 123732)
> +++ build/common.gypi   (working copy)
> @@ -208,6 +208,7 @@
>       # -faddress-sanitizer only works with clang, but asan=1 implies
> clang=1
>       # See https://sites.google.com/a/**chromium.org/dev/developers/**
>
testing/addresssanitizer<https://sites.google.com/a/chromium.org/dev/developers/testing/addresssanitizer>
>       'asan%': 0,
> +      'asan_blacklist%': '<(PRODUCT_DIR)/../../third_**
> party/asan/ignore.txt',
>
>       # Use the provided profiled order file to link Chrome image with it.
>       # This makes Chrome faster by better using CPU cache when executing
> code.
> @@ -458,6 +459,7 @@
>     'notifications%': '<(notifications)',
>     'clang_use_chrome_plugins%': '<(clang_use_chrome_plugins)',
>     'asan%': '<(asan)',
> +    'asan_blacklist%': '<(asan_blacklist)',
>     'order_text_section%': '<(order_text_section)',
>     'enable_register_protocol_**handler%': '<(enable_register_protocol_**
> handler)',
>     'enable_web_intents%': '<(enable_web_intents)',
> @@ -1964,7 +1966,7 @@
>               '-faddress-sanitizer',
>               '-fno-omit-frame-pointer',
>               '-w',
> -              '-mllvm', '-asan-blacklist=<(PRODUCT_**
> DIR)/../../third_party/asan/**ignore.txt',
> +              '-mllvm', '-asan-blacklist=<(asan_**blacklist)',
>             ],
>             'ldflags': [
>               '-faddress-sanitizer',
> @@ -2381,7 +2383,7 @@
>               'OTHER_CFLAGS': [
>                 '-faddress-sanitizer',
>                 '-w',
> -                '-mllvm', '-asan-blacklist=<(PRODUCT_**
> DIR)/../../third_party/asan/**ignore.txt',
> +                '-mllvm', '-asan-blacklist=<(asan_**blacklist)',
>               ],
>               'OTHER_LDFLAGS': [
>                 '-faddress-sanitizer',
>
>
>

[Alexander Potapenko, 2012-02-28 07:10:15]

I'm not sure how "BUG=chromium-os:26919" got into the description without any
action from my side, but done.

[Nico, 2012-02-28 07:12:07]

LGTM, thanks :-)