Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: chrome/browser/net/connection_tester_unittest.cc

Issue 9476035: Make CertVerifier a pure virtual interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win shared fix Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/connection_tester.cc ('k') | chrome/service/net/service_url_request_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/connection_tester_unittest.cc
===================================================================
--- chrome/browser/net/connection_tester_unittest.cc (revision 128056)
+++ chrome/browser/net/connection_tester_unittest.cc (working copy)
@@ -108,7 +108,7 @@
net::TestServer test_server_;
ConnectionTesterDelegate test_delegate_;
net::MockHostResolver host_resolver_;
- net::CertVerifier cert_verifier_;
+ scoped_ptr<net::CertVerifier> cert_verifier_;
scoped_ptr<net::ProxyService> proxy_service_;
scoped_refptr<net::SSLConfigService> ssl_config_service_;
scoped_ptr<net::HttpTransactionFactory> http_transaction_factory_;
@@ -119,7 +119,8 @@
private:
void InitializeRequestContext() {
proxy_script_fetcher_context_->set_host_resolver(&host_resolver_);
- proxy_script_fetcher_context_->set_cert_verifier(&cert_verifier_);
+ cert_verifier_.reset(net::CertVerifier::CreateDefault());
+ proxy_script_fetcher_context_->set_cert_verifier(cert_verifier_.get());
proxy_script_fetcher_context_->set_http_auth_handler_factory(
&http_auth_handler_factory_);
proxy_service_.reset(net::ProxyService::CreateDirect());
@@ -127,7 +128,7 @@
ssl_config_service_ = new net::SSLConfigServiceDefaults;
net::HttpNetworkSession::Params session_params;
session_params.host_resolver = &host_resolver_;
- session_params.cert_verifier = &cert_verifier_;
+ session_params.cert_verifier = cert_verifier_.get();
session_params.http_auth_handler_factory = &http_auth_handler_factory_;
session_params.ssl_config_service = ssl_config_service_;
session_params.proxy_service = proxy_service_.get();
« no previous file with comments | « chrome/browser/net/connection_tester.cc ('k') | chrome/service/net/service_url_request_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698