Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: media/tools/layout_tests/layouttest_analyzer_helpers_unittest.py

Issue 9476021: Updating Layout test analyzer to add control to show issue detail or not. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Modification based on CR comments. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/tools/layout_tests/layouttest_analyzer_helpers_unittest.py
diff --git a/media/tools/layout_tests/layouttest_analyzer_helpers_unittest.py b/media/tools/layout_tests/layouttest_analyzer_helpers_unittest.py
old mode 100755
new mode 100644
index 05acf8ddfb43f61cfa02e71af0a55e2e9a10a85c..4408be72860f77c8f9631f9cb2c9d2fd002c25ef
--- a/media/tools/layout_tests/layouttest_analyzer_helpers_unittest.py
+++ b/media/tools/layout_tests/layouttest_analyzer_helpers_unittest.py
@@ -1,5 +1,5 @@
#!/usr/bin/env python
-# Copyright (c) 2011 The Chromium Authors. All rights reserved.
+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
@@ -122,9 +122,9 @@ class TestLayoutTestAnalyzerHelpers(unittest.TestCase):
diff_map = None
else:
diff_map = {
- 'whole': [[], []],
- 'skip': [[(testname, 'te_info1')], []],
- 'nonskip': [[], []],
+ 'whole': [[], []],
+ 'skip': [[(testname, 'te_info1')], []],
+ 'nonskip': [[], []],
}
(rev_str, simple_rev_str, rev_number, rev_date) = (
layouttest_analyzer_helpers.GetRevisionString(prev_time, current_time,
@@ -142,9 +142,11 @@ class TestLayoutTestAnalyzerHelpers(unittest.TestCase):
'94377</a>\n'
'<li>jamesr@google.com</li>\n'
'<li>2011-09-01 18:00:23</li>\n'
- '<ul><li>-BUGWK63878 : fast/dom/dom-constructors.html'
- ' = TEXT</li>\n'
- '</ul></ul>')
+ '<ul><li>-<a href="http://webkit.org/b/63878">'
+ 'BUGWK63878</a> : <a href=\'http://test-results.'
+ 'appspot.com/dashboards/flakiness_dashboard.html#'
+ 'tests=fast/dom/dom-constructors.html\'>fast/dom/'
+ 'dom-constructors.html</a> = TEXT</li>\n</ul></ul>')
expected_simple_rev_str = ('<a href="http://trac.webkit.org/changeset?'
'new=94377@trunk/LayoutTests/platform/chromium/'
'test_expectations.txt&old=94366@trunk/'
« no previous file with comments | « media/tools/layout_tests/layouttest_analyzer_helpers.py ('k') | media/tools/layout_tests/layouttest_analyzer_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698