Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: media/tools/layout_tests/bug.py

Issue 9476021: Updating Layout test analyzer to add control to show issue detail or not. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: One minor change. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/tools/layout_tests/bug.py
diff --git a/media/tools/layout_tests/bug.py b/media/tools/layout_tests/bug.py
index df9b5f70fc2dd44a49f5f88efa48eb17e71e824c..42dd17dd1d8f0d829587076d0f454e7051e3140e 100644
--- a/media/tools/layout_tests/bug.py
+++ b/media/tools/layout_tests/bug.py
@@ -1,4 +1,4 @@
-# Copyright (c) 2011 The Chromium Authors. All rights reserved.
+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
@@ -31,26 +31,29 @@ class Bug(object):
currently, BUGWK12345, BUGCR12345, BUGV8_12345, BUGDPRANKE are
possible.
"""
- self.bug_txt = bug_modifier
- pattern_for_webkit_bug = r'BUGWK(\d+)'
+ pattern_for_webkit_bug = r'(BUGWK(\d+))'
match = re.search(pattern_for_webkit_bug, bug_modifier)
if match:
self.type = self.WEBKIT
- self.url = self.WEBKIT_BUG_URL + match.group(1)
+ self.url = self.WEBKIT_BUG_URL + match.group(2)
+ self.bug_txt = match.group(1)
return
- pattern_for_chrome_bug = r'BUGCR(\d+)'
+ pattern_for_chrome_bug = r'(BUGCR(\d+))'
match = re.search(pattern_for_chrome_bug, bug_modifier)
if match:
self.type = self.CHROMIUM
- self.url = self.CHROME_BUG_URL + match.group(1)
+ self.url = self.CHROME_BUG_URL + match.group(2)
+ self.bug_txt = match.group(1)
return
- pattern_for_other_bug = r'BUG(\S+)'
+ pattern_for_other_bug = r'(BUG(\S+))'
match = re.search(pattern_for_other_bug, bug_modifier)
if match:
self.type = self.OTHERS
- self.url = 'mailto:%s@chromium.org' % match.group(1).lower()
+ self.url = 'mailto:%s@chromium.org' % match.group(2).lower()
+ self.bug_txt = match.group(1)
return
self.url = ''
+ self.bug_txt = ''
def __str__(self):
"""Get a string representation of a bug object.

Powered by Google App Engine
This is Rietveld 408576698