media/tools/layout_tests/test_expectations_unittest.py - Issue 9476021: Updating Layout test analyzer to add control to show issue detail or not.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/tools/layout_tests/test_expectations_unittest.py

Issue 9476021: Updating Layout test analyzer to add control to show issue detail or not. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/tools/layout_tests/layouttests.py ('K') | « media/tools/layout_tests/test_expectations_history_unittest.py ('k') | media/tools/layout_tests/testname/media.csv » ('j') | media/tools/layout_tests/trend_graph.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/tools/layout_tests/test_expectations_unittest.py

diff --git a/media/tools/layout_tests/test_expectations_unittest.py b/media/tools/layout_tests/test_expectations_unittest.py

old mode 100755

new mode 100644

index dc60b7d814550bd9b8565bb24c99b35aa9deee36..9c6b8eaee785bdecc038eaa38219c1ce358a45c8

--- a/media/tools/layout_tests/test_expectations_unittest.py

+++ b/media/tools/layout_tests/test_expectations_unittest.py

@@ -11,7 +11,7 @@ from test_expectations import TestExpectations

class TestTestExpectations(unittest.TestCase):

def testParseLine(self):

- line = "BUGCR86714 MAC GPU : media/video-zoom.html = CRASH IMAGE"

+ line = 'BUGCR86714 MAC GPU : media/video-zoom.html = CRASH IMAGE'

comments = 'Comments'

expected_map = {'CRASH': True, 'IMAGE': True, 'Bugs': ['BUGCR86714'],

'Comments': 'Comments', 'MAC': True, 'GPU': True}

@@ -19,7 +19,7 @@ class TestTestExpectations(unittest.TestCase):

expected_map)

def testParseLineWithLineComments(self):

- line = "BUGCR86714 MAC GPU : media/video-zoom.html = CRASH IMAGE // foo"

+ line = 'BUGCR86714 MAC GPU : media/video-zoom.html = CRASH IMAGE // foo'

comments = 'Comments'

expected_map = {'CRASH': True, 'IMAGE': True, 'Bugs': ['BUGCR86714'],

'Comments': 'Comments foo', 'MAC': True, 'GPU': True}

@@ -27,7 +27,7 @@ class TestTestExpectations(unittest.TestCase):

expected_map)

def testParseLineWithLineGPUComments(self):

- line = "BUGCR86714 MAC : media/video-zoom.html = CRASH IMAGE // GPU"

+ line = 'BUGCR86714 MAC : media/video-zoom.html = CRASH IMAGE // GPU'

comments = 'Comments'

expected_map = {'CRASH': True, 'IMAGE': True, 'Bugs': ['BUGCR86714'],

'Comments': 'Comments GPU', 'MAC': True}