media/tools/layout_tests/test_expectations.py - Issue 9476021: Updating Layout test analyzer to add control to show issue detail or not.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/tools/layout_tests/test_expectations.py

Issue 9476021: Updating Layout test analyzer to add control to show issue detail or not. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Modification based on CR comments. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « media/tools/layout_tests/layouttests_unittest.py ('k') | media/tools/layout_tests/test_expectations_history.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """A module to analyze test expectations for Webkit layout tests."""	5 """A module to analyze test expectations for Webkit layout tests."""

6	6

7 import re	7 import re

8 import urllib2	8 import urllib2

9	9

10 # Default Webkit SVN location for chromium test expectation file.	10 # Default Webkit SVN location for chromium test expectation file.

11 # TODO(imasaki): support multiple test expectations files.	11 # TODO(imasaki): support multiple test expectations files.

(...skipping 134 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
146 line = line[0:line.rindex('//')]	146 line = line[0:line.rindex('//')]

147 for name in ALL_TE_KEYWORDS:	147 for name in ALL_TE_KEYWORDS:

148 if name in line:	148 if name in line:

149 test_expectation_info[name] = True	149 test_expectation_info[name] = True

150 test_expectation_info['Comments'] = comment_prefix + inline_comments	150 test_expectation_info['Comments'] = comment_prefix + inline_comments

151 # Store bug informations.	151 # Store bug informations.

152 bugs = re.findall(r'BUG\w+', line)	152 bugs = re.findall(r'BUG\w+', line)

153 if bugs:	153 if bugs:

154 test_expectation_info['Bugs'] = bugs	154 test_expectation_info['Bugs'] = bugs

155 return test_expectation_info	155 return test_expectation_info

OLD	NEW