Updating Layout test analyzer to add control to show issue detail or not.

media/tools/layout_tests/trend_graph.py

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A module for manipulating trend graph with analyzer result history."""
 
 import os
-import sys
 
 import layouttest_analyzer_helpers
 
 DEFAULT_TREND_GRAPH_PATH = os.path.join('graph', 'graph.html')
 
 # The following is necesasry to decide the point to insert.
 LINE_INSERT_POINT_FOR_NUMBERS = r'// insert 1'
 LINE_INSERT_POINT_FOR_PASSING_RATE = r'// insert 2'
 
 
-class TrendGraph(object):
+class TrendGraph:

[dennis_jeffrey, 2012/02/29 17:50:32]

curious: why did you remove the "(object)" from here?

[imasaki1, 2012/03/02 19:12:07]

Mistake. I bring it back

   """A class to manage trend graph which is using Google Visualization APIs.
 
   Google Visualization API (http://code.google.com/apis/chart/interactive/docs/
   gallery/annotatedtimeline.html) is used to present the historical analyzer
   result. Currently, data is directly written to JavaScript file using file
   in-place replacement for simplicity.
 
   TODO(imasaki): use GoogleSpreadsheet to store the analyzer result.
   """
 
@@ skipping 15 matching lines @@
           'passingrate' as its keys and (number, tile, text) string tuples
           as values for graph annotation.
     """
     joined_str = ''
     # For a date format in GViz, month is shifted (e.g., '2008,2,1' means
     # March 1, 2008). So, the input parameter |datetime_string| (before this
     # conversion) must be shifted in order to show the date properly on GViz.
     # After the below conversion, for example, in the case of the year 2008,
     # |datetime_string| ranges from '2008,0,1,0,0,00' to '2008,11,31,23,59,99'.
     str_list = datetime_string.split(',')
-    str_list[1] = str(int(str_list[1])-1) # month
+    str_list[1] = str(int(str_list[1])-1)  # Month
     datetime_string = ','.join(str_list)
     for key in ['whole', 'skip', 'nonskip']:
       joined_str += str(len(data_map[key][0])) + ','
       joined_str += ','.join(data_map[key][1:]) + ','
     new_line_for_numbers = '         [new Date(%s),%s],\n' % (datetime_string,
                                                               joined_str)
     new_line_for_numbers += '         %s\n' % (
         LINE_INSERT_POINT_FOR_NUMBERS)
     layouttest_analyzer_helpers.ReplaceLineInFile(
         self._location, LINE_INSERT_POINT_FOR_NUMBERS,
         new_line_for_numbers)
 
     joined_str = '%s,%s,%s' % (
         str(data_map['passingrate'][0]), data_map['nonskip'][1],
         data_map['nonskip'][2])
     new_line_for_passingrate = '         [new Date(%s),%s],\n' % (
         datetime_string, joined_str)
     new_line_for_passingrate += '         %s\n' % (
         LINE_INSERT_POINT_FOR_PASSING_RATE)
     layouttest_analyzer_helpers.ReplaceLineInFile(
         self._location, LINE_INSERT_POINT_FOR_PASSING_RATE,
         new_line_for_passingrate)