Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome/browser/metrics/metrics_log.h

Issue 9474041: Upload UMA data using protocol buffers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix crash in test Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_log.cc » ('j') | chrome/browser/metrics/metrics_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_log.h
diff --git a/chrome/browser/metrics/metrics_log.h b/chrome/browser/metrics/metrics_log.h
index a5a3504cc6f51adca77798e2825edae7ade1f2be..5935139a58133d6e8119b08d9ab250e35254c7f8 100644
--- a/chrome/browser/metrics/metrics_log.h
+++ b/chrome/browser/metrics/metrics_log.h
@@ -65,18 +65,25 @@ class MetricsLog : public MetricsLogBase {
// Record recent delta for critical stability metrics. We can't wait for a
// restart to gather these, as that delay biases our observation away from
// users that run happily for a looooong time. We send increments with each
- // uma log upload, just as we send histogram data.
- void RecordIncrementalStabilityElements();
+ // uma log upload, just as we send histogram data. Takes the list of
+ // installed plugins as a parameter because that can't be obtained
+ // synchronously from the UI thread.
+ void RecordIncrementalStabilityElements(
+ const std::vector<webkit::WebPluginInfo>& plugin_list);
private:
FRIEND_TEST_ALL_PREFIXES(MetricsLogTest, ChromeOSStabilityData);
// Writes application stability metrics (as part of the profile log).
// NOTE: Has the side-effect of clearing those counts.
- void WriteStabilityElement(PrefService* pref);
+ void WriteStabilityElement(
+ const std::vector<webkit::WebPluginInfo>& plugin_list,
+ PrefService* pref);
// Within stability group, write plugin crash stats.
- void WritePluginStabilityElements(PrefService* pref);
+ void WritePluginStabilityElements(
+ const std::vector<webkit::WebPluginInfo>& plugin_list,
+ PrefService* pref);
// Within the stability group, write required attributes.
void WriteRequiredStabilityAttributes(PrefService* pref);
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_log.cc » ('j') | chrome/browser/metrics/metrics_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698