Issue 9474041: Upload UMA data using protocol buffers.

Issue 9474041: Upload UMA data using protocol buffers. (Closed)

Created:
8 years, 9 months ago by Ilya Sherman

Modified:
7 years ago

Reviewers:
Nico, jar (doing other things)

CC:
chromium-reviews, robertshield, MAD, Ilya Sherman, jar (doing other things), amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Upload UMA data using protocol buffers. For now, we will also preserve the existing XML upload system, so that there is no risk of data loss. Previously committed as [ https://chromiumcodereview.appspot.com/9232071/ ]. This fixes the ChromiumOS compile. BUG=109817 TEST=unit tested TBR=jar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124086

Patch Set 2 : Fix up unit test compile #

Patch Set 3 : Fix crash in test #

Total comments: 4

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1164 lines, -542 lines)			Patch
M	chrome/browser/metrics/metrics_log.h	View		1 chunk	+11 lines, -4 lines	0 comments	Download
M	chrome/browser/metrics/metrics_log.cc	View	1 2	16 chunks	+333 lines, -67 lines	0 comments	Download
M	chrome/browser/metrics/metrics_log_serializer.h	View		3 chunks	+20 lines, -12 lines	0 comments	Download
M	chrome/browser/metrics/metrics_log_serializer.cc	View		7 chunks	+95 lines, -48 lines	0 comments	Download
M	chrome/browser/metrics/metrics_log_serializer_unittest.cc	View		7 chunks	+63 lines, -55 lines	0 comments	Download
M	chrome/browser/metrics/metrics_log_unittest.cc	View	1	6 chunks	+11 lines, -177 lines	0 comments	Download
M	chrome/browser/metrics/metrics_service.h	View	1 2	1 chunk	+12 lines, -4 lines	0 comments	Download
M	chrome/browser/metrics/metrics_service.cc	View	1 2	15 chunks	+142 lines, -48 lines	1 comment	Download
M	chrome/chrome_tests.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/metrics/metrics_log_base.h	View		5 chunks	+28 lines, -17 lines	0 comments	Download
M	chrome/common/metrics/metrics_log_base.cc	View		12 chunks	+135 lines, -66 lines	2 comments	Download
A	chrome/common/metrics/metrics_log_base_unittest.cc	View		1 chunk	+195 lines, -0 lines	0 comments	Download
M	chrome/common/metrics/metrics_log_manager.h	View		5 chunks	+40 lines, -13 lines	0 comments	Download
M	chrome/common/metrics/metrics_log_manager.cc	View		5 chunks	+48 lines, -15 lines	1 comment	Download
M	chrome/common/metrics/metrics_log_manager_unittest.cc	View		4 chunks	+15 lines, -9 lines	0 comments	Download
M	chrome/common/pref_names.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/common/pref_names.cc	View		1 chunk	+8 lines, -4 lines	0 comments	Download
M	chrome_frame/metrics_service.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

Minor drive-by :-) https://chromiumcodereview.appspot.com/9474041/diff/4001/chrome/browser/metrics/metrics_service.cc File chrome/browser/metrics/metrics_service.cc (right): https://chromiumcodereview.appspot.com/9474041/diff/4001/chrome/browser/metrics/metrics_service.cc#newcode223 chrome/browser/metrics/metrics_service.cc:223: const int kInitializationDelaySeconds = 30; const ...

8 years, 9 months ago (2012-02-29 02:53:06 UTC) #1

Nico

https://chromiumcodereview.appspot.com/9474041/diff/4001/chrome/common/metrics/metrics_log_base.cc File chrome/common/metrics/metrics_log_base.cc (right): https://chromiumcodereview.appspot.com/9474041/diff/4001/chrome/common/metrics/metrics_log_base.cc#newcode181 chrome/common/metrics/metrics_log_base.cc:181: bool result = Time::FromString(kDateTime, &time); Hey, should this use ...

7 years ago (2013-12-05 01:49:30 UTC) #2

Ilya Sherman

7 years ago (2013-12-05 01:54:28 UTC) #3

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/9474041/diff/4001/chrome/common/metric...
File chrome/common/metrics/metrics_log_base.cc (right):

https://chromiumcodereview.appspot.com/9474041/diff/4001/chrome/common/metric...
chrome/common/metrics/metrics_log_base.cc:181: bool result =
Time::FromString(kDateTime, &time);
On 2013/12/05 01:49:31, Nico wrote:
> Hey, should this use base/build_time.h instead? Then we won't have two build
> times with disagreeing timezones (this uses GMT, base uses PST)

I'm not sure, but this code currently matches what the server expects.  I'm not
actively working on UMA presently, but I'll email the current team asking them
to take a look.  Thanks for pointing it out :)

Expand Messages | Collapse Messages