Issue 9467021: Attempt 3: Makes managed mode constrain the height of windows so they don't

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9467021: Attempt 3: Makes managed mode constrain the height of windows so they don't (Closed)

Created:
8 years, 10 months ago by sky

Modified:
8 years, 10 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Attempt 3: Makes managed mode constrain the height of windows so they don't overlap the launcher. BUG=115581 TEST=see bug, covered by unit tests too Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123603

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+505 lines, -124 lines)			Patch
M	ash/ash.gyp	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	ash/wm/toplevel_window_event_filter.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	ash/wm/toplevel_window_event_filter.cc	View		4 chunks	+10 lines, -4 lines	0 comments	Download
M	ash/wm/toplevel_window_event_filter_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/wm/window_resizer.h	View		2 chunks	+11 lines, -3 lines	0 comments	Download
M	ash/wm/window_resizer.cc	View		2 chunks	+14 lines, -4 lines	0 comments	Download
M	ash/wm/workspace/workspace_event_filter.h	View		1 chunk	+6 lines, -16 lines	0 comments	Download
M	ash/wm/workspace/workspace_event_filter.cc	View		4 chunks	+9 lines, -46 lines	0 comments	Download
M	ash/wm/workspace/workspace_layout_manager.h	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	ash/wm/workspace/workspace_layout_manager.cc	View		2 chunks	+6 lines, -34 lines	0 comments	Download
A	ash/wm/workspace/workspace_window_resizer.h	View		1 chunk	+52 lines, -0 lines	0 comments	Download
A	ash/wm/workspace/workspace_window_resizer.cc	View		1 chunk	+113 lines, -0 lines	0 comments	Download
A	ash/wm/workspace/workspace_window_resizer_unittest.cc	View		1 chunk	+274 lines, -0 lines	0 comments	Download
M	ui/aura/screen_aura.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

sky

Patchset 1 is last commit, patchset 2 is the fix. I changed ScreenAura to use ...

8 years, 10 months ago (2012-02-25 00:20:01 UTC) #1

lgtm