Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 9467007: Support ImplementedBy idl attribute. (Closed)

Created:
8 years, 10 months ago by podivilov
Modified:
8 years, 10 months ago
Reviewers:
antonm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support ImplementedBy idl attribute. R=antonm@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=4617

Patch Set 1 #

Total comments: 1

Patch Set 2 : Deal with DOM exceptions in one place. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -109 lines) Patch
M client/dom/scripts/systemnative.py View 1 9 chunks +111 lines, -109 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
podivilov
8 years, 10 months ago (2012-02-24 17:08:34 UTC) #1
antonm
https://chromiumcodereview.appspot.com/9467007/diff/1/client/dom/scripts/systemnative.py File client/dom/scripts/systemnative.py (right): https://chromiumcodereview.appspot.com/9467007/diff/1/client/dom/scripts/systemnative.py#newcode784 client/dom/scripts/systemnative.py:784: raises_dom_exceptions): I don't like how ec handling is now ...
8 years, 10 months ago (2012-02-24 19:01:40 UTC) #2
antonm
8 years, 10 months ago (2012-02-27 13:17:32 UTC) #3
LGTM!

I'd suggest different formatting: not to put too many arguments into one line
but instead doing something like

foo(
  arg1,
  arg2)

That's ways more readable imho, but I am not insisting.

http://codereview.chromium.org/9467007/diff/3001/client/dom/scripts/systemnat...
File client/dom/scripts/systemnative.py (right):

http://codereview.chromium.org/9467007/diff/3001/client/dom/scripts/systemnat...
client/dom/scripts/systemnative.py:303:
self._GenerateNativeCallback(callback_name='constructorCallback',
nit: I'd prefer to callback_name='...' on a separate line

Powered by Google App Engine
This is Rietveld 408576698