Remove now unused CalculateExactRetainedSize function & сo.

Remove now unused CalculateExactRetainedSize function & co.

This patch changes the signature of the v8::HeapGraphNode::GetRetainedSize method, but it's not used in Chromium, and it should be easy for other clients (if any) to adjust to this change.

BUG=none
TEST=none

Committed: https://code.google.com/p/v8/source/detail?r=10846

[alexeif, 2012-02-24 18:00:28]

Misha,

Could you please take a look.

Thank you!

[mnaganov (inactive), 2012-02-24 23:19:50]

https://chromiumcodereview.appspot.com/9466014/diff/1/test/cctest/test-heap-p...
File test/cctest/test-heap-profiler.cc (left):

https://chromiumcodereview.appspot.com/9466014/diff/1/test/cctest/test-heap-p...
test/cctest/test-heap-profiler.cc:110: CHECK(det.has_A2);
I'm against removing this code. It checks that A2, B2 and C2 functions are
reachable from the global object. Just a sanity check that we don't produce
broken snapshots. Please restore it or replace with an equivalent.

[alexeif, 2012-02-27 11:57:25]

Thanks for the review. Added it back.

https://chromiumcodereview.appspot.com/9466014/diff/1/test/cctest/test-heap-p...
File test/cctest/test-heap-profiler.cc (left):

https://chromiumcodereview.appspot.com/9466014/diff/1/test/cctest/test-heap-p...
test/cctest/test-heap-profiler.cc:110: CHECK(det.has_A2);
On 2012/02/24 23:19:50, Mikhail Naganov (Chromium) wrote:
> I'm against removing this code. It checks that A2, B2 and C2 functions are
> reachable from the global object. Just a sanity check that we don't produce
> broken snapshots. Please restore it or replace with an equivalent.

Done.

[mnaganov (inactive), 2012-02-27 14:22:47]

On 2012/02/27 11:57:25, alexeif wrote:
> Thanks for the review. Added it back.
> 
>
https://chromiumcodereview.appspot.com/9466014/diff/1/test/cctest/test-heap-p...
> File test/cctest/test-heap-profiler.cc (left):
> 
>
https://chromiumcodereview.appspot.com/9466014/diff/1/test/cctest/test-heap-p...
> test/cctest/test-heap-profiler.cc:110: CHECK(det.has_A2);
> On 2012/02/24 23:19:50, Mikhail Naganov (Chromium) wrote:
> > I'm against removing this code. It checks that A2, B2 and C2 functions are
> > reachable from the global object. Just a sanity check that we don't produce
> > broken snapshots. Please restore it or replace with an equivalent.
> 
> Done.

Alexei, I'm getting test failures with your patch. Can you please re-check?

Almost in every test from cctest/heap-profiler (debug flavour):

>>> running tests for x64.debug
=== debug test-heap-profiler BoundFunctionInSnapshot ===
Path: cctest/test-heap-profiler/BoundFunctionInSnapshot
#
# Fatal error in ../src/profile-generator.h, line 564
# CHECK(!painted_) failed
#

[mnaganov (inactive), 2012-02-27 15:40:49]

LGTM, landing.