Use the component information when the test is being scheduled instead of when it's being created.

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 159 matching lines @@
   }
 }
 
 
 class TestInformation {
   String filename;
   Map optionsFromFile;
   bool isNegative;
   bool isNegativeIfChecked;
   bool hasFatalTypeErrors;
+  bool hasRuntimeErrors;
 
   TestInformation(this.filename, this.optionsFromFile, this.isNegative,
-                  this.isNegativeIfChecked, this.hasFatalTypeErrors);
+                  this.isNegativeIfChecked, this.hasFatalTypeErrors,
+                  this.hasRuntimeErrors);
 }
 
 
 /**
  * A standard [TestSuite] implementation that searches for tests in a
  * directory, and creates [TestCase]s that compile and/or run them.
  */
 class StandardTestSuite implements TestSuite {
   Map configuration;
   String suiteName;
@@ skipping 96 matching lines @@
     // See if there's a 'src' directory inside the 'tests' one.
     int testsStart = filename.lastIndexOf('tests/');
     int start = filename.lastIndexOf('src/');
     if (start > testsStart) {
       testName = filename.substring(start + 4, filename.length - 5);
     } else if (optionsFromFile['isMultitest']) {
       start = filename.lastIndexOf('/');
       int middle = filename.lastIndexOf('_');
       testName = filename.substring(start + 1, middle) + '/' +
           filename.substring(middle + 1, filename.length - 5);
+      if ((configuration['component'] == 'dartc') && info.hasRuntimeErrors) {
+        isNegative = false;
+      }

[Bill Hesse, 2012/02/24 13:58:36]

I think this could be moved to line 345, since runtimeErrors is only true for
multitests, you don't need the guard.

[ngeoffray, 2012/02/24 14:08:10]

Done.

     } else {
       // This case is hit by the dartc client compilation
       // tests. These tests are pretty broken compared to the
       // rest. They use the .dart suffix in the status files. They
       // find tests in weird ways (testing that they contain "#").
       // They need to be redone.
       // TODO(1058): This does not work on Windows.
       start = filename.indexOf(directoryPath);
       if (start != -1) {
         testName = filename.substring(start + directoryPath.length + 1);
@@ skipping 29 matching lines @@
         // errors with a flag and treat tests that have fatal type
         // errors as negative.
         var enableFatalTypeErrors =
             (info.hasFatalTypeErrors && configuration['component'] == 'dartc');
         var argumentLists = argumentListsFromFile(filename,
                                                   optionsFromFile,
                                                   enableFatalTypeErrors);
         isNegative = isNegative ||
             (configuration['checked'] && info.isNegativeIfChecked) ||
             enableFatalTypeErrors;
 

[Bill Hesse, 2012/02/24 13:58:36]

It could be put down here, at the other place isNegative is changed.  But it is
find where it is.

         for (var args in argumentLists) {
           doTest(new TestCase('$suiteName/$testName',
                               shellPath(),
                               args,
                               configuration,
                               completeHandler,
                               expectations,
                               isNegative));
         }
     }
   }
 
   Function makeTestCaseCreator(Map optionsFromFile) {
     return (String filename,
             bool isNegative,
             [bool isNegativeIfChecked = false,
-             bool hasFatalTypeErrors = false]) {
+             bool hasFatalTypeErrors = false,
+             bool hasRuntimeErrors = false]) {
       // Cache the test information for each test case.
       var info = new TestInformation(filename,
                                      optionsFromFile,
                                      isNegative,
                                      isNegativeIfChecked,
-                                     hasFatalTypeErrors);
+                                     hasFatalTypeErrors,
+                                     hasRuntimeErrors);
       cachedTests.add(info);
       enqueueTestCaseFromTestInformation(info);
     };
   }
 
   void processFile(String filename) {
     if (!isTestFile(filename)) return;
 
     // Only run the tests that match the pattern.
     RegExp pattern = configuration['selectors'][suiteName];
@@ skipping 744 matching lines @@
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
 """;
     print(report);
    }
 }