AppBanner: add requirement for an 144x144 image/png icon.

chrome/browser/android/banners/app_banner_manager.cc

Index: chrome/browser/android/banners/app_banner_manager.cc
diff --git a/chrome/browser/android/banners/app_banner_manager.cc b/chrome/browser/android/banners/app_banner_manager.cc
index a579f652fae1bddb26a61cc8fcadee0a5ed54ea8..22c0ac7f2d010743ff8b6122d804f95d9b5e1927 100644
--- a/chrome/browser/android/banners/app_banner_manager.cc
+++ b/chrome/browser/android/banners/app_banner_manager.cc
@@ -9,6 +9,7 @@
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
+#include "base/strings/string_util.h"
 #include "chrome/browser/android/banners/app_banner_infobar_delegate.h"
 #include "chrome/browser/android/manifest_icon_selector.h"
 #include "chrome/browser/android/shortcut_helper.h"
@@ -43,10 +44,29 @@ using base::android::ConvertUTF8ToJavaString;
 using base::android::ConvertUTF16ToJavaString;
 
 namespace {
+
 const char kBannerTag[] = "google-play-id";
 base::TimeDelta gTimeDeltaForTesting;
 bool gDisableSecureCheckForTesting = false;
-}  // namespace
+
+// The requirement for now is an image/png that is at least 144x144.
+bool DoesManifestContainRequiredIcon(const content::Manifest& manifest) {
+  for (const auto& icon : manifest.icons) {
+    if (EqualsASCII(icon.type.string(), "image/png"))
+      continue;
+
+    for (const auto& size : icon.sizes) {
+      if (size.IsEmpty()) // "any"
+        return true;
+      if (size.width() >= 144 && size.height() >= 144)

[gone, 2015/02/20 17:36:41]

Make 144 a constant up above.

+        return true;
+    }
+  }
+
+  return false;
+}
+
+}  // anonymous namespace
 
 namespace banners {
 
@@ -150,7 +170,8 @@ void AppBannerManager::OnDidGetManifest(const content::Manifest& manifest) {
 
   if (manifest.IsEmpty()
       || !manifest.start_url.is_valid()
-      || (manifest.name.is_null() && manifest.short_name.is_null())) {
+      || (manifest.name.is_null() && manifest.short_name.is_null())
+      || !DoesManifestContainRequiredIcon(manifest)) {
     // No usable manifest, see if there is a play store meta tag.
     Send(new ChromeViewMsg_RetrieveMetaTagContent(routing_id(),
                                                   validated_url_,