Issue 9465041: Better mangling in frog for fixing parts of issue 1837.

Issue 9465041: Better mangling in frog for fixing parts of issue 1837. (Closed)

Created:
8 years, 10 months ago by ngeoffray

Modified:
8 years, 10 months ago

Reviewers:
vsm, kasperl, sra1

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Better mangling in frog for fixing parts of issue 1837. Committed: https://code.google.com/p/dart/source/detail?r=4595

Patch Set 2 : #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -19 lines)			Patch
M	client/tests/client/client.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
A	client/tests/client/dom/WindowManglingTest.dart	View		1 chunk	+33 lines, -0 lines	0 comments	Download
A	client/tests/client/dom/WindowNSMETest.dart	View	1	1 chunk	+52 lines, -0 lines	0 comments	Download
M	frog/corejs.dart	View	1	8 chunks	+12 lines, -12 lines	0 comments	Download
M	frog/lang.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	frog/leg/ssa/js_names.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	frog/member.dart	View	1	4 chunks	+8 lines, -4 lines	0 comments	Download
M	frog/member_set.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sra1

lgtm https://chromiumcodereview.appspot.com/9465041/diff/1/client/tests/client/dom/WindowNSMETest.dart File client/tests/client/dom/WindowNSMETest.dart (right): https://chromiumcodereview.appspot.com/9465041/diff/1/client/tests/client/dom/WindowNSMETest.dart#newcode17 client/tests/client/dom/WindowNSMETest.dart:17: var win = new Unused(); It is a ...

8 years, 10 months ago (2012-02-25 22:43:36 UTC) #2

ngeoffray

8 years, 10 months ago (2012-02-26 17:33:07 UTC) #3

https://chromiumcodereview.appspot.com/9465041/diff/1/client/tests/client/dom...
File client/tests/client/dom/WindowNSMETest.dart (right):

https://chromiumcodereview.appspot.com/9465041/diff/1/client/tests/client/dom...
client/tests/client/dom/WindowNSMETest.dart:17: var win = new Unused();
On 2012/02/25 22:43:36, sra1 wrote:
> It is a good idea to write tests where the operations on a variable like win
> happen in two contexts:
> 
> (1) dynamic context, where the type of win cannot be inferred by the compiler,
> even with dataflow.  
> 
> (2) statically typed context, i.e.  Unused win = new Unused();
> 
> This should detect problems with either foo$0() or foo()

Done, thanks for the suggestions Stephen.

Expand Messages | Collapse Messages