Issue 9465013: Mike's change.

Issue 9465013: Mike's change. (Closed)

Created:
8 years, 10 months ago by robertshield

Modified:
8 years, 10 months ago

Reviewers:
mgraboski, Roger Tawa OOO till Jul 10th

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mike's change to allow the type of reactivation to be specified based on current elevation level. I added some minor style changes and fixed up the tests. BUG=NONE TEST=gcapi_test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123755

Patch Set 1 #

Patch Set 2 : Fixing up tests #

Patch Set 3 : Removing unneeded line breaks. #

Total comments: 12

Patch Set 4 : Addressing Roger's feedback. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -50 lines)			Patch
M	chrome/installer/gcapi/gcapi.h	View	1 2 3	3 chunks	+24 lines, -5 lines	0 comments	Download
M	chrome/installer/gcapi/gcapi.cc	View	1 2 3	5 chunks	+32 lines, -17 lines	0 comments	Download
M	chrome/installer/gcapi/gcapi_omaha_experiment.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/gcapi/gcapi_omaha_experiment.cc	View		3 chunks	+11 lines, -3 lines	0 comments	Download
M	chrome/installer/gcapi/gcapi_reactivation.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/gcapi/gcapi_reactivation.cc	View	1 2 3	2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/installer/gcapi/gcapi_reactivation_test.cc	View	1	6 chunks	+39 lines, -18 lines	0 comments	Download
M	chrome/installer/gcapi/gcapi_test.cc	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Roger Tawa OOO till Jul 10th

lgtm A few nits below. I'm not sure I fully understand all the flows, but ...

8 years, 10 months ago (2012-02-24 21:46:59 UTC) #2

robertshield

8 years, 10 months ago (2012-02-24 22:21:40 UTC) #3

Thanks, PTAL!

http://codereview.chromium.org/9465013/diff/4001/chrome/installer/gcapi/gcapi.cc
File chrome/installer/gcapi/gcapi.cc (right):

http://codereview.chromium.org/9465013/diff/4001/chrome/installer/gcapi/gcapi...
chrome/installer/gcapi/gcapi.cc:36: 
On 2012/02/24 21:46:59, Roger Tawa wrote:
> why extra space?

Done.

http://codereview.chromium.org/9465013/diff/4001/chrome/installer/gcapi/gcapi...
chrome/installer/gcapi/gcapi.cc:594: std::back_inserter(reactivation_brands));
On 2012/02/24 21:46:59, Roger Tawa wrote:
> above: indent 4 more.

Done.

http://codereview.chromium.org/9465013/diff/4001/chrome/installer/gcapi/gcapi...
chrome/installer/gcapi/gcapi.cc:599: return FALSE;
On 2012/02/24 21:46:59, Roger Tawa wrote:
> indent if(error_code) block

Done.

http://codereview.chromium.org/9465013/diff/4001/chrome/installer/gcapi/gcapi.h
File chrome/installer/gcapi/gcapi.h (right):

http://codereview.chromium.org/9465013/diff/4001/chrome/installer/gcapi/gcapi...
chrome/installer/gcapi/gcapi.h:27: // Flags to indicate whether GCAPI is invoked
On 2012/02/24 21:46:59, Roger Tawa wrote:
> whether -> how ?

Done.

http://codereview.chromium.org/9465013/diff/4001/chrome/installer/gcapi/gcapi...
chrome/installer/gcapi/gcapi.h:41: // will set the flag only if Chrome can be
offered.
On 2012/02/24 21:46:59, Roger Tawa wrote:
> add a description for new arg.  same below.

Done.

http://codereview.chromium.org/9465013/diff/4001/chrome/installer/gcapi/gcapi...
File chrome/installer/gcapi/gcapi_reactivation.cc (right):

http://codereview.chromium.org/9465013/diff/4001/chrome/installer/gcapi/gcapi...
chrome/installer/gcapi/gcapi_reactivation.cc:55: }
On 2012/02/24 21:46:59, Roger Tawa wrote:
> no need for { and }

Done.

Expand Messages | Collapse Messages