Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6655)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/extension.cc

Issue 9465005: Updating the doc to reflect the new experimental.keybinding API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/extensions/docs/static/experimental.keybinding.html ('K') | « chrome/common/extensions/docs/static/experimental.keybinding.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.cc
===================================================================
--- chrome/common/extensions/extension.cc (revision 123480)
+++ chrome/common/extensions/extension.cc (working copy)
@@ -281,7 +281,7 @@
// We support Ctrl+foo, Alt+foo, Ctrl+Shift+foo, Alt+Shift+foo, but not
// Ctrl+Alt+foo. For a more detailed reason why we don't support Ctrl+Alt+foo:
// http://blogs.msdn.com/b/oldnewthing/archive/2004/03/29/101121.aspx.
- if (key == ui::VKEY_UNKNOWN || (ctrl == true && alt == true)) {
+ if (key == ui::VKEY_UNKNOWN || (ctrl && alt)) {
*error = ExtensionErrorUtils::FormatErrorMessageUTF16(
errors::kInvalidKeyBinding,
base::IntToString(index),
« chrome/common/extensions/docs/static/experimental.keybinding.html ('K') | « chrome/common/extensions/docs/static/experimental.keybinding.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698