Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: runtime/bin/extensions.h

Issue 9465004: Add native extensions for the Dart shell to mac and windows (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use shared library (dylib) on Mac (and therefore for all platforms). Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/builtin_impl_sources.gypi ('k') | runtime/bin/extensions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/extensions.h
diff --git a/runtime/bin/extensions.h b/runtime/bin/extensions.h
index fda8f1e4d41754e1f9591496fdd7d55f262b33ac..b62c7637afc1e18b8809311142cd527b99cee0e5 100644
--- a/runtime/bin/extensions.h
+++ b/runtime/bin/extensions.h
@@ -10,13 +10,19 @@
class Extensions {
public:
- // TODO(whesse): Make loading extensions lazy, so dynamic library is loaded
- // only when first native function is called.
// TODO(whesse): Make extension load from a relative path relative to
// the library it is in. Currently loads from current working directory.
static Dart_Handle LoadExtension(const char* extension_url,
- Dart_Handle library);
+ Dart_Handle parent_library);
+
private:
+ // The returned string must be freed.
+ static char* Concatenate(const char** strings);
+
+ // Platform-specific implementations.
+ static void* LoadExtensionLibrary(const char* library_name);
+ static void* ResolveSymbol(void* lib_handle, const char* symbol);
+
DISALLOW_ALLOCATION();
DISALLOW_IMPLICIT_CONSTRUCTORS(Extensions);
};
« no previous file with comments | « runtime/bin/builtin_impl_sources.gypi ('k') | runtime/bin/extensions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698