Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Side by Side Diff: src/isolate.cc

Issue 9464054: Do not call memset() to initialize StubCache. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comments Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/stub-cache.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1818 matching lines...) Expand 10 before | Expand all | Expand 10 after
1829 } 1829 }
1830 1830
1831 if (FLAG_preemption) { 1831 if (FLAG_preemption) {
1832 v8::Locker locker; 1832 v8::Locker locker;
1833 v8::Locker::StartPreemption(100); 1833 v8::Locker::StartPreemption(100);
1834 } 1834 }
1835 1835
1836 #ifdef ENABLE_DEBUGGER_SUPPORT 1836 #ifdef ENABLE_DEBUGGER_SUPPORT
1837 debug_->SetUp(create_heap_objects); 1837 debug_->SetUp(create_heap_objects);
1838 #endif 1838 #endif
1839 stub_cache_->Initialize(create_heap_objects);
1840 1839
1841 // If we are deserializing, read the state into the now-empty heap. 1840 // If we are deserializing, read the state into the now-empty heap.
1842 if (des != NULL) { 1841 if (des != NULL) {
1843 des->Deserialize(); 1842 des->Deserialize();
1844 stub_cache_->Initialize(true);
1845 } 1843 }
1844 stub_cache_->Initialize();
1846 1845
1847 // Finish initialization of ThreadLocal after deserialization is done. 1846 // Finish initialization of ThreadLocal after deserialization is done.
1848 clear_pending_exception(); 1847 clear_pending_exception();
1849 clear_pending_message(); 1848 clear_pending_message();
1850 clear_scheduled_exception(); 1849 clear_scheduled_exception();
1851 1850
1852 // Deserializing may put strange things in the root array's copy of the 1851 // Deserializing may put strange things in the root array's copy of the
1853 // stack guard. 1852 // stack guard.
1854 heap_.SetStackLimits(); 1853 heap_.SetStackLimits();
1855 1854
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
1952 1951
1953 #ifdef DEBUG 1952 #ifdef DEBUG
1954 #define ISOLATE_FIELD_OFFSET(type, name, ignored) \ 1953 #define ISOLATE_FIELD_OFFSET(type, name, ignored) \
1955 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_); 1954 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_);
1956 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET) 1955 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET)
1957 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET) 1956 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET)
1958 #undef ISOLATE_FIELD_OFFSET 1957 #undef ISOLATE_FIELD_OFFSET
1959 #endif 1958 #endif
1960 1959
1961 } } // namespace v8::internal 1960 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/stub-cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698