Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: chrome/browser/resources/options2/chromeos/accounts_options.js

Issue 9464053: Hide/Disable several (meaningless) options in Settings uber-page for Guest. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: No change picture button anymore Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/chromeos/accounts_options.js
diff --git a/chrome/browser/resources/options2/chromeos/accounts_options.js b/chrome/browser/resources/options2/chromeos/accounts_options.js
index e4c0651a0666e68dc189469b9fed9bb5e057dbce..a6c9db098d5fc7e8b7f84dd2987323f87d3fd90b 100644
--- a/chrome/browser/resources/options2/chromeos/accounts_options.js
+++ b/chrome/browser/resources/options2/chromeos/accounts_options.js
@@ -160,6 +160,35 @@ cr.define('options', function() {
$('userList').updateAccountPicture(username);
};
+ /**
+ * Disable and mark page elements that does not make sense in Guest mode.
James Hawkins 2012/02/28 20:03:35 s/does/do/
James Hawkins 2012/02/28 20:03:35 Don't use statements about things 'making sense' i
Denis Kuznetsov (DE-MUC) 2012/02/29 08:41:43 Done.
Denis Kuznetsov (DE-MUC) 2012/02/29 08:41:43 Done.
+ */
+ AccountsOptions.disableElementsForGuest = function(element) {
James Hawkins 2012/02/28 20:03:35 Document |element|.
Denis Kuznetsov (DE-MUC) 2012/02/29 08:41:43 Done.
+ AccountsOptions.disableElementForGuest_(element);
+
+ // Walk the tree, searching each ELEMENT node.
+ var walker = document.createTreeWalker(element,
+ NodeFilter.SHOW_ELEMENT,
+ null,
+ false);
+
+ var node = walker.nextNode();
+ while (node) {
+ AccountsOptions.disableElementForGuest_(node);
+ node = walker.nextNode();
+ }
+ };
+
+ AccountsOptions.disableElementForGuest_ = function(element) {
James Hawkins 2012/02/28 20:03:35 Document method.
Denis Kuznetsov (DE-MUC) 2012/02/29 08:41:43 Done.
+ element.classList.add('guest-disabled')
+ if (element.nodeName == 'INPUT' ||
+ element.nodeName == 'SELECT' ||
+ element.nodeName == 'BUTTON')
+ element.disabled = true;
+ if (element.nodeName == 'A')
+ element.removeAttribute('href');
+ };
+
// Export
return {
AccountsOptions: AccountsOptions

Powered by Google App Engine
This is Rietveld 408576698