Chromium Code Reviews Chromium Code Reviews
Issue 9464053:
Hide/Disable several (meaningless) options in Settings uber-page for Guest. (Closed)
Base URL: http://git.chromium.org/chromium/src.git@master| Index: chrome/browser/resources/options2/browser_options.html |
| diff --git a/chrome/browser/resources/options2/browser_options.html b/chrome/browser/resources/options2/browser_options.html |
| index c19e10147618b30e04335a1a40c2358c7a4be168..adb3339d5e1b404e9eab22d15d71e88581d89b09 100644 |
| --- a/chrome/browser/resources/options2/browser_options.html |
| +++ b/chrome/browser/resources/options2/browser_options.html |
| @@ -113,7 +113,7 @@ |
| <button id="themes-reset" i18n-content="themesReset"></button> |
| </div> |
| </if> |
| - <div class="settings-row"> |
| + <div class="settings-row" id="home-page-select-container"> |
|
James Hawkins
2012/03/05 17:07:12
nit: IDs should be the first attribute.
Denis Kuznetsov (DE-MUC)
2012/03/12 10:32:15
Done.
|
| <span i18n-content="homePage"></span> |
| <select id="home-page-select"> |
| <option value="none" i18n-content="homePageNone"></option> |
| @@ -122,7 +122,7 @@ |
| <option value="choose" i18n-content="homePageChoose"></option> |
| </select> |
| </div> |
| - <div class="checkbox"><label> |
| + <div id="bookmarkbar-show-on-all-tabs-group" class="checkbox"><label> |
| <input type="checkbox" pref="bookmark_bar.show_on_all_tabs" |
| metric="Options_ShowBookmarksBar"> |
| <span i18n-content="toolbarShowBookmarksBar"></span> |
| @@ -199,7 +199,7 @@ |
| </div> |
| </div> |
| </section> |
| - <section> |
| + <section id="users-section"> |
| <h3 i18n-content="sectionTitleUsers"></h3> |
| <if expr="pp_ifdef('chromeos')"> |
| <div id="sync-section"> |
| @@ -281,10 +281,13 @@ |
| <section> |
| <h3 i18n-content="datetimeTitle"></h3> |
| <div class="option-control-table"> |
| - <span class="option-name" i18n-content="timezone"></span> |
| - <div id="timezone-value"> |
| - <select id="timezone-select" class="control" i18n-options="timezoneList" |
| - data-type="string" pref="cros.system.timezone"></select> |
| + <div id="timezone-value-group"> |
| + <span class="option-name" i18n-content="timezone"></span> |
| + <div id="timezone-value"> |
| + <select id="timezone-select" class="control" |
| + i18n-options="timezoneList" data-type="string" |
| + pref="cros.system.timezone"></select> |
|
James Hawkins
2012/03/05 17:07:12
nit: Closing tag should be on a new line.
Denis Kuznetsov (DE-MUC)
2012/03/12 10:32:15
Done.
|
| + </div> |
| </div> |
| <div class="checkbox"> |
| <label> |
| @@ -323,14 +326,14 @@ |
| <span i18n-content="linkDoctorPref"></span> |
| </label> |
| </div> |
| - <div class="checkbox"> |
| + <div id="search-suggest-enabled-group" class="checkbox"> |
| <label> |
| <input id="searchSuggestEnabled" pref="search.suggest_enabled" |
| metric="Options_UseSuggestCheckbox" type="checkbox"> |
| <span i18n-content="suggestPref"></span> |
| </label> |
| </div> |
| - <div class="checkbox"> |
| + <div id="dns-prefetching-enabled-group" class="checkbox"> |
| <label> |
| <input id="dnsPrefetchingEnabled" pref="dns_prefetching.enabled" |
| metric="Options_DnsPrefetchCheckbox" type="checkbox"> |
