Fix for issue 1835: record the 'final' information in the DeclaredIdentifier.

frog/gen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Top level generator object for writing code and keeping track of
  * dependencies.
  *
  * Should have two compilation models, but only one implemented so far.
  *
@@ skipping 1556 matching lines @@
     var itemType = method.resolveType(node.item.type, false, true);
     var list = node.list.visit(this);
     _visitLoop(node, () {
       _visitForInBody(node, itemType, list);
     });
     return false;
   }
 
   void _visitForInBody(ForInStatement node, Type itemType, Value list) {
     // TODO(jimhug): Check that itemType matches list members...
-    bool isFinal = _isFinal(node.item.type);
+    bool isFinal = node.item.isFinal;
     var itemName = node.item.name.name;
     var item = _scope.create(itemName, itemType, node.item.name.span, isFinal);
     if (list.needsTemp) {
       var listVar = _scope.create('\$list', list.type, null);
       writer.writeln('var ${listVar.code} = ${list.code};');
       list = listVar;
     }
 
     // Special path for concrete Arrays for readability and perf optimization.
     if (list.type.genericType == world.listFactoryType) {
@@ skipping 870 matching lines @@
     return true;
   }
 
 }
 
 class ReturnKind {
   static final int IGNORE = 1;
   static final int POST = 2;
   static final int PRE = 3;
 }