Issue 9463052: When compiling for-in pass correct context value to the increment instruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9463052: When compiling for-in pass correct context value to the increment instruction. (Closed)

Created:
8 years, 10 months ago by Vyacheslav Egorov (Chromium)

Modified:
8 years, 10 months ago

Reviewers:
Florian Schneider, fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

When compiling for-in pass correct context value to the increment instruction. Additionally force increment instruction to use int32 representation. R=fschneider@google.com BUG=http://crbug.com/115646 TEST=test/mjsunit/compiler/optimized-for-in.js Committed: https://code.google.com/p/v8/source/detail?r=10844

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -15 lines)			Patch
M	src/flag-definitions.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen.cc	View	3 chunks	+6 lines, -7 lines	0 comments	Download
M	test/mjsunit/compiler/optimized-for-in.js	View	3 chunks	+9 lines, -7 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fschneider

8 years, 10 months ago (2012-02-27 13:53:06 UTC) #2

LGTM.

https://chromiumcodereview.appspot.com/9463052/diff/1/test/mjsunit/compiler/o...
File test/mjsunit/compiler/optimized-for-in.js (right):

https://chromiumcodereview.appspot.com/9463052/diff/1/test/mjsunit/compiler/o...
test/mjsunit/compiler/optimized-for-in.js:252: r += t[x][i];
Replace \t with spaces.

Expand Messages | Collapse Messages