Issue 9463051: Enable the keybinding test for TOOLKIT_VIEWS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9463051: Enable the keybinding test for TOOLKIT_VIEWS. (Closed)

Created:
8 years, 10 months ago by Finnur

Modified:
8 years, 10 months ago

Reviewers:
Jói

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Enable the keybinding test for TOOLKIT_VIEWS. BUG=27702 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123734

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/extensions/extension_keybinding_apitest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói

8 years, 10 months ago (2012-02-27 13:56:47 UTC) #2

LGTM

On Mon, Feb 27, 2012 at 1:55 PM,  <finnur@chromium.org> wrote:
> Reviewers: Jói,
>
> Description:
> Enable the keybinding test for TOOLKIT_VIEWS.
>
> BUG=27702
> TEST=None
>
> Please review this at https://chromiumcodereview.appspot.com/9463051/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/extensions/extension_keybinding_apitest.cc
>
>
> Index: chrome/browser/extensions/extension_keybinding_apitest.cc
> ===================================================================
> --- chrome/browser/extensions/extension_keybinding_apitest.cc   (revision
> 123480)
> +++ chrome/browser/extensions/extension_keybinding_apitest.cc   (working
> copy)
> @@ -37,7 +37,7 @@
>   }
>  };
>
> -#if defined(OS_WIN)  // Not implemented on other platforms yet.
> +#if defined(TOOLKIT_VIEWS)
>  IN_PROC_BROWSER_TEST_F(KeybindingApiTest, Basic) {
>   ASSERT_TRUE(test_server()->Start());
>   ASSERT_TRUE(RunExtensionTest("keybinding/basics")) << message_;
> @@ -78,4 +78,4 @@
>       &result));
>   ASSERT_TRUE(result);
>  }
> -#endif  // OS_WIN
> +#endif  // TOOLKIT_VIEWS
>
>

Expand Messages | Collapse Messages