Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Side by Side Diff: src/hydrogen.cc

Issue 9463049: Disable for-in support in Crankshaft while crashes and regressions are being investigated. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/flag-definitions.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3224 matching lines...) Expand 10 before | Expand all | Expand 10 after
3235 break_info.break_block()); 3235 break_info.break_block());
3236 set_current_block(loop_exit); 3236 set_current_block(loop_exit);
3237 } 3237 }
3238 3238
3239 3239
3240 void HGraphBuilder::VisitForInStatement(ForInStatement* stmt) { 3240 void HGraphBuilder::VisitForInStatement(ForInStatement* stmt) {
3241 ASSERT(!HasStackOverflow()); 3241 ASSERT(!HasStackOverflow());
3242 ASSERT(current_block() != NULL); 3242 ASSERT(current_block() != NULL);
3243 ASSERT(current_block()->HasPredecessor()); 3243 ASSERT(current_block()->HasPredecessor());
3244 3244
3245 if (!FLAG_optimize_for_in) {
3246 return Bailout("ForInStatement optimization is disabled");
3247 }
3248
3245 if (!stmt->each()->IsVariableProxy() || 3249 if (!stmt->each()->IsVariableProxy() ||
3246 !stmt->each()->AsVariableProxy()->var()->IsStackLocal()) { 3250 !stmt->each()->AsVariableProxy()->var()->IsStackLocal()) {
3247 return Bailout("ForInStatement with non-local each variable"); 3251 return Bailout("ForInStatement with non-local each variable");
3248 } 3252 }
3249 3253
3250 Variable* each_var = stmt->each()->AsVariableProxy()->var(); 3254 Variable* each_var = stmt->each()->AsVariableProxy()->var();
3251 3255
3252 CHECK_ALIVE(VisitForValue(stmt->enumerable())); 3256 CHECK_ALIVE(VisitForValue(stmt->enumerable()));
3253 HValue* enumerable = Top(); // Leave enumerable at the top. 3257 HValue* enumerable = Top(); // Leave enumerable at the top.
3254 3258
(...skipping 4641 matching lines...) Expand 10 before | Expand all | Expand 10 after
7896 } 7900 }
7897 } 7901 }
7898 7902
7899 #ifdef DEBUG 7903 #ifdef DEBUG
7900 if (graph_ != NULL) graph_->Verify(false); // No full verify. 7904 if (graph_ != NULL) graph_->Verify(false); // No full verify.
7901 if (allocator_ != NULL) allocator_->Verify(); 7905 if (allocator_ != NULL) allocator_->Verify();
7902 #endif 7906 #endif
7903 } 7907 }
7904 7908
7905 } } // namespace v8::internal 7909 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/flag-definitions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698